From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13352 invoked by alias); 13 May 2011 22:31:20 -0000 Received: (qmail 13343 invoked by uid 22791); 13 May 2011 22:31:19 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 May 2011 22:31:06 +0000 Received: from hpaq5.eem.corp.google.com (hpaq5.eem.corp.google.com [172.25.149.5]) by smtp-out.google.com with ESMTP id p4DMV4rj031105 for ; Fri, 13 May 2011 15:31:04 -0700 Received: from pxi16 (pxi16.prod.google.com [10.243.27.16]) by hpaq5.eem.corp.google.com with ESMTP id p4DMUv3D012797 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 13 May 2011 15:31:02 -0700 Received: by pxi16 with SMTP id 16so2124717pxi.32 for ; Fri, 13 May 2011 15:30:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.143.136.1 with SMTP id o1mr1091322wfn.188.1305325857189; Fri, 13 May 2011 15:30:57 -0700 (PDT) Received: by 10.142.234.20 with HTTP; Fri, 13 May 2011 15:30:57 -0700 (PDT) In-Reply-To: <4DCDAF89.9010804@redhat.com> References: <20110427184248.B8B122225CD@jade.mtv.corp.google.com> <4DBB6F71.4070604@redhat.com> <4DCDAF89.9010804@redhat.com> Date: Sat, 14 May 2011 07:01:00 -0000 Message-ID: Subject: Re: [patch] Split Parse Timevar (rev 2) (issue4433076) From: Lawrence Crowl To: Jason Merrill Cc: reply@codereview.appspotmail.com, dnovillo@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01025.txt.bz2 On 5/13/11, Jason Merrill wrote: > I'm applying this patch to fix a crash that I get when running cc1plus > directly without -quiet; all the other TV_OVERLOAD bits use > timevar_cond_*, so it seems that these should too. > > Tested x86_64-pc-linux-gnu, applying to trunk. Looks good to me. -- Lawrence Crowl