From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9449 invoked by alias); 12 Apr 2011 14:38:23 -0000 Received: (qmail 9439 invoked by uid 22791); 12 Apr 2011 14:38:23 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Apr 2011 14:38:19 +0000 Received: by wye20 with SMTP id 20so6796758wye.20 for ; Tue, 12 Apr 2011 07:38:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.182.135 with SMTP id cc7mr207065wbb.91.1302619062031; Tue, 12 Apr 2011 07:37:42 -0700 (PDT) Received: by 10.227.0.140 with HTTP; Tue, 12 Apr 2011 07:37:42 -0700 (PDT) In-Reply-To: <20110412143205.GG23480@codesourcery.com> References: <20110412141626.GF23480@codesourcery.com> <20110412143205.GG23480@codesourcery.com> Date: Tue, 12 Apr 2011 14:38:00 -0000 Message-ID: Subject: Re: [PATCH] add statistics counting to postreload, copy-rename, and math-opts From: Richard Guenther To: Nathan Froyd Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00892.txt.bz2 On Tue, Apr 12, 2011 at 4:32 PM, Nathan Froyd wr= ote: > On Tue, Apr 12, 2011 at 04:27:01PM +0200, Richard Guenther wrote: >> On Tue, Apr 12, 2011 at 4:16 PM, Nathan Froyd = wrote: >> > It's a shame more passes don't make use of the statistics_* >> > infrastructure. =A0This patch is a step towards rectifying that and ad= ds >> > statistics_counter_event calls to passes mentioned in $SUBJECT. >> > postreload-gcse already tracked the stats for the dump file and so only >> > needs the statistics_counter_event calls; the other passes needed to be >> > taught about the statistics also. >> >> Ok if there are no complaints within 24h. =A0I actually have a local pat= ch >> adding many of these which I use whenever fiddling with the pass pipelin= e ... >> (attached). > > Thanks. =A0I may go twiddle that patch to do something similar to mine and > submit that. =A0Do you use your patch for checking that the same set of > optimizations get performed, then? =A0I'm interested in using the > statistics for identifying passes that don't buy us much across a wide > variety of codebases. =A0(Suggestions for suitable ones welcome!) Yes, I used it exactly for that. And also to verify that passes don't do anything if replicated (well, for those that shouldn't at least). Don't expect any low-hanging fruit though ;) I catched all of it already. Candidates are obviously SPEC and GCC itself. I also use tramp3d of course. That said, even if a pass does nearly nothing we often have testcases that need it ... Richard. > -Nathan >