From: Lawrence Crowl <crowl@google.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: Diego Novillo <dnovillo@google.com>,
reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [pph] Macro Validation Correction (issue4425041)
Date: Mon, 25 Apr 2011 18:58:00 -0000 [thread overview]
Message-ID: <BANLkTi=Qy-5iLZCcbCb6L6-hjAnQFCx9Kg@mail.gmail.com> (raw)
In-Reply-To: <alpine.BSF.2.00.1104222007370.71229@dair.pair.com>
On 4/22/11, Hans-Peter Nilsson <hp@bitrange.com> wrote:
> On Sat, 16 Apr 2011, Diego Novillo wrote:
>> On Thu, Apr 14, 2011 at 22:01, Lawrence Crowl <crowl@google.com> wrote:
>> > +unsigned char too_many_directives_for_bitfield[
>> > + N_DIRECTIVES <= (1 << CPP_HASHNODE_INDEX_BITS)
>> > + ? 1 : -1];
>>
>> Heh, I'm not sure what to think of this trick. I think I like it, though.
>
> One up: better make it a declaration: prepend with "extern".
I will fold that into my next patch.
--
Lawrence Crowl
prev parent reply other threads:[~2011-04-25 18:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 3:39 Lawrence Crowl
2011-04-16 17:37 ` Diego Novillo
2011-04-18 13:34 ` Tom Tromey
2011-04-18 19:04 ` Lawrence Crowl
2011-04-18 19:23 ` Diego Novillo
2011-04-23 0:50 ` Hans-Peter Nilsson
2011-04-25 18:58 ` Lawrence Crowl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=Qy-5iLZCcbCb6L6-hjAnQFCx9Kg@mail.gmail.com' \
--to=crowl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).