From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30920 invoked by alias); 24 May 2011 15:14:51 -0000 Received: (qmail 30904 invoked by uid 22791); 24 May 2011 15:14:50 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-pw0-f47.google.com (HELO mail-pw0-f47.google.com) (209.85.160.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 15:14:31 +0000 Received: by pwj9 with SMTP id 9so3269797pwj.20 for ; Tue, 24 May 2011 08:14:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.249.39 with SMTP id w39mr1109044wfh.96.1306250070352; Tue, 24 May 2011 08:14:30 -0700 (PDT) Received: by 10.142.108.7 with HTTP; Tue, 24 May 2011 08:14:30 -0700 (PDT) In-Reply-To: References: Date: Tue, 24 May 2011 16:43:00 -0000 Message-ID: Subject: Re: [build] Fix Solaris 2/x86 GD/LD TLS code sequences with Sun ld From: Uros Bizjak To: Rainer Orth Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=001636ed6a186e638704a4070bd7 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01733.txt.bz2 --001636ed6a186e638704a4070bd7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1080 On Tue, May 24, 2011 at 5:09 PM, Rainer Orth wrote: >> Since handling of "p" is not conditional (that is, controlled by some >> compile flag), it is IMO better to just output correct assembly from >> the insn pattern itself. =A0You will also output lower-case "@plt" which > > I think I tried something along these lines, but failed with duplicate > @plt@plt for PIC code. Hm, there is no %P1 present, so I don't think this should be an issue. >> is IIRC preferred by Sun assebler. > > I've never seen such an issue. OK, it is your call... please change @plt to @PLT if desired. >> Something like attached (untested) patch. > > Unfortunately, the Solaris 10/x86 bootstrap fails in the stage1 libgomp: > > /vol/gcc/src/hg/trunk/solaris/libgomp/single.c: In function 'GOMP_single_= start': > /vol/gcc/src/hg/trunk/solaris/libgomp/single.c:55:1: internal compiler er= ror: ou > tput_operand: '%&' used without any local dynamic TLS references Yeah, I found the problem in tlsgdplt template, please find attached new version of the patch... Uros. --001636ed6a186e638704a4070bd7 Content-Type: text/plain; charset=US-ASCII; name="t.diff.txt" Content-Disposition: attachment; filename="t.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_go2zhxgp0 Content-length: 1713 SW5kZXg6IGkzODYubWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaTM4 Ni5tZAkocmV2aXNpb24gMTc0MTE5KQorKysgaTM4Ni5tZAkod29ya2luZyBj b3B5KQpAQCAtMTIzNjcsNiArMTIzNjcsMTIgQEAKIHsKICAgb3V0cHV0X2Fz bV9pbnNuCiAgICAgKCJsZWF7bH1cdHslYTJAdGxzZ2QoLCUxLDEpLCAlMHwl MCwgJWEyQHRsc2dkWyUxKjFdfSIsIG9wZXJhbmRzKTsKKyAgaWYgKFRBUkdF VF9TVU5fVExTKQorI2lmZGVmIEhBVkVfQVNfSVg4Nl9UTFNHRFBMVAorICAg IHJldHVybiAiY2FsbFx0JWEyQHRsc2dkcGx0IjsKKyNlbHNlCisgICAgcmV0 dXJuICJjYWxsXHQlYTNAcGx0IjsKKyNlbmRpZgogICByZXR1cm4gImNhbGxc dCVQMyI7CiB9CiAgIFsoc2V0X2F0dHIgInR5cGUiICJtdWx0aSIpCkBAIC0x MjM5Nyw2ICsxMjQwMyw4IEBACiAgICAgKCJsZWF7cX1cdHslYTFAdGxzZ2Qo JSVyaXApLCAlJXJkaXxyZGksICVhMUB0bHNnZFtyaXBdfSIsIG9wZXJhbmRz KTsKICAgZnB1dHMgKEFTTV9TSE9SVCAiMHg2NjY2XG4iLCBhc21fb3V0X2Zp bGUpOwogICBmcHV0cyAoIlx0cmV4NjRcbiIsIGFzbV9vdXRfZmlsZSk7Cisg IGlmIChUQVJHRVRfU1VOX1RMUykKKyAgICByZXR1cm4gImNhbGxcdCVhMkBw bHQiOwogICByZXR1cm4gImNhbGxcdCVQMiI7CiB9CiAgIFsoc2V0X2F0dHIg InR5cGUiICJtdWx0aSIpCkBAIC0xMjQyNCw2ICsxMjQzMiwxMiBAQAogewog ICBvdXRwdXRfYXNtX2luc24KICAgICAoImxlYXtsfVx0eyUmQHRsc2xkbSgl MSksICUwfCUwLCAlJkB0bHNsZG1bJTFdfSIsIG9wZXJhbmRzKTsKKyAgaWYg KFRBUkdFVF9TVU5fVExTKQorI2lmZGVmIEhBVkVfQVNfSVg4Nl9UTFNMRE1Q TFQKKyAgICByZXR1cm4gImNhbGxcdCUmQHRsc2xkbXBsdCI7CisjZWxzZQor ICAgIHJldHVybiAiY2FsbFx0JWEyQHBsdCI7CisjZW5kaWYKICAgcmV0dXJu ICJjYWxsXHQlUDIiOwogfQogICBbKHNldF9hdHRyICJ0eXBlIiAibXVsdGki KQpAQCAtMTI0NTAsNiArMTI0NjQsOCBAQAogewogICBvdXRwdXRfYXNtX2lu c24KICAgICAoImxlYXtxfVx0eyUmQHRsc2xkKCUlcmlwKSwgJSVyZGl8cmRp LCAlJkB0bHNsZFtyaXBdfSIsIG9wZXJhbmRzKTsKKyAgaWYgKFRBUkdFVF9T VU5fVExTKQorICAgIHJldHVybiAiY2FsbFx0JWExQHBsdCI7CiAgIHJldHVy biAiY2FsbFx0JVAxIjsKIH0KICAgWyhzZXRfYXR0ciAidHlwZSIgIm11bHRp IikK --001636ed6a186e638704a4070bd7--