From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, Martin Jambor <mjambor@suse.cz>,
Richard Guenther <rguenther@suse.de>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix incorrect devirtualization (PR middle-end/48661)
Date: Tue, 19 Apr 2011 00:07:00 -0000 [thread overview]
Message-ID: <BANLkTi=e8CKmAuN5hLSY3F=9yF=Pm3XSpw@mail.gmail.com> (raw)
In-Reply-To: <20110418214008.GE17079@tyan-ft48-01.lab.bos.redhat.com>
On Mon, Apr 18, 2011 at 2:40 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> If TREE_BINFO has BV_VCALL_INDEX set, this needs to be dynamically
> adjusted, but none of the callers are prepared to handle that.
> Thus, this patch makes devirtualization give up in those cases.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, trunk and 4.6.
> On the trunk the testcase ICEs before and after the patch in some new callgraph
> checking (added today or so, Honza?), on the branch it works just fine.
>
> Ok for trunk/4.6?
>
> 2011-04-18 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/48661
> * gimple-fold.c (gimple_get_virt_method_for_binfo): Return NULL
> if TREE_TYPE (v) is non-NULL.
>
> * gimple-fold.c (gimple_get_virt_method_for_binfo): Renamed from
> gimple_get_virt_mehtod_for_binfo.
> * gimple.h (gimple_get_virt_method_for_binfo): Likewise.
> * ipa-cp.c (ipcp_process_devirtualization_opportunities): Adjust
> callers.
> * ipa-prop.c (try_make_edge_direct_virtual_call): Likewise.
>
> * g++.dg/torture/pr48661.C: New test.
>
This caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48674
--
H.J.
next prev parent reply other threads:[~2011-04-18 23:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 22:33 Jakub Jelinek
2011-04-18 23:35 ` Richard Guenther
2011-04-18 23:43 ` Jason Merrill
2011-04-19 7:46 ` Jakub Jelinek
2011-04-19 23:37 ` Jason Merrill
2011-04-20 14:32 ` Martin Jambor
2011-04-19 0:07 ` H.J. Lu [this message]
2011-04-19 0:21 ` Jan Hubicka
2011-04-19 0:24 ` Jan Hubicka
2011-04-19 8:58 ` Richard Guenther
2011-04-19 10:27 ` Jan Hubicka
2011-04-19 10:51 ` Richard Guenther
2011-04-19 11:12 ` Jan Hubicka
2011-04-19 11:30 ` Richard Guenther
2011-04-19 14:59 ` Jan Hubicka
2011-04-19 14:59 ` Richard Guenther
2011-04-19 15:00 ` Jan Hubicka
2011-04-20 14:50 ` Martin Jambor
2011-04-20 15:06 ` Jan Hubicka
2011-04-20 15:25 ` Richard Guenther
2011-04-20 15:35 ` Jan Hubicka
2011-04-20 15:28 ` Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=e8CKmAuN5hLSY3F=9yF=Pm3XSpw@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=mjambor@suse.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).