From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31743 invoked by alias); 18 Apr 2011 23:43:54 -0000 Received: (qmail 31727 invoked by uid 22791); 18 Apr 2011 23:43:53 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Apr 2011 23:43:39 +0000 Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7]) by smtp-out.google.com with ESMTP id p3INhbmG015109 for ; Mon, 18 Apr 2011 16:43:37 -0700 Received: from ywh1 (ywh1.prod.google.com [10.192.8.1]) by hpaq7.eem.corp.google.com with ESMTP id p3INhZFF032614 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 18 Apr 2011 16:43:36 -0700 Received: by ywh1 with SMTP id 1so2206597ywh.1 for ; Mon, 18 Apr 2011 16:43:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.31.4 with SMTP id e4mr4579050ybe.127.1303170215071; Mon, 18 Apr 2011 16:43:35 -0700 (PDT) Received: by 10.150.212.19 with HTTP; Mon, 18 Apr 2011 16:43:35 -0700 (PDT) In-Reply-To: References: <90e6ba6e83a062ca6d04a136d37f@google.com> Date: Tue, 19 Apr 2011 00:15:00 -0000 Message-ID: Subject: Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047) From: Diego Novillo To: Richard Guenther Cc: martint@google.com, davidxl@google.com, gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01473.txt.bz2 On Mon, Apr 18, 2011 at 17:24, Richard Guenther wrote: > On Mon, Apr 18, 2011 at 9:59 PM, =C2=A0 wrote: >> LGTM >> >> >> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c >> File gcc/libgcov.c (right): >> >> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155 >> gcc/libgcov.c:155: filename? filename : "", e, v); >> Better split it into two different printfs as the format is different -- >> otherwise double : will be printed. >> >> http://codereview.appspot.com/4446047/ > > I'm confused. =C2=A0Can we please avoid this kind of mails? It's not altogether easy. I filed an enhancement request for Rietveld, but I'm not sure how eager they will be to implement this. http://code.google.com/p/rietveld/issues/detail?id=3D291&sort=3D-id Two workarounds: - Reply to the patch using the Reply button in the web interface. - Reply using to the initial e-mail generated by Rietveld. - Cut and paste context from the window when replying via the web interface. Medium/long term, we could probably install our own Rietveld instance in gcc.gnu.org and modify it to our taste. Either that or look for another patch review tool. If anyone has any other suggestions, please let me know. Diego.