From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16569 invoked by alias); 19 May 2011 11:01:13 -0000 Received: (qmail 16561 invoked by uid 22791); 19 May 2011 11:01:12 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 11:00:59 +0000 Received: by wye20 with SMTP id 20so2245192wye.20 for ; Thu, 19 May 2011 04:00:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.54.6 with SMTP id o6mr2958844wbg.61.1305802857691; Thu, 19 May 2011 04:00:57 -0700 (PDT) Received: by 10.227.38.129 with HTTP; Thu, 19 May 2011 04:00:57 -0700 (PDT) In-Reply-To: <201105191245.02882.ebotcazou@adacore.com> References: <201105191245.02882.ebotcazou@adacore.com> Date: Thu, 19 May 2011 12:59:00 -0000 Message-ID: Subject: Re: [patch gimplifier]: Change TRUTH_(AND|OR|XOR) expressions to binary form From: Richard Guenther To: Eric Botcazou Cc: Kai Tietz , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01367.txt.bz2 On Thu, May 19, 2011 at 12:45 PM, Eric Botcazou wro= te: >> Eric, how will this interact with Ada boolean types with 8 bit precision >> and those "invalid" values - will invalid values ever enter into >> expressions or are they checked before? > > IIUC the Ada semantics is that they must be checked prior to being used. = =A0Once > they are used, they are "recycled" into valid values. =A0So the issue boi= ls down > to how the check is implemented and it doesn't use TRUTH_(AND|OR|XOR) at = all. > >> Can you think of something that would break with s/TRUTH_*_EXPR/BIT_*_EX= PR/ >> for Ada? > > No, not at the moment. =A0Thanks for asking in any case. Kai, the patch is ok then with the comment added. Thanks, Richard. > -- > Eric Botcazou >