From: Lawrence Crowl <crowl@google.com>
To: crowl@google.com, dnovillo@google.com, froydnj@codesourcery.com,
gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com
Subject: Re: [pph] More C++ Tree Nodes (issue4526083)
Date: Fri, 27 May 2011 19:18:00 -0000 [thread overview]
Message-ID: <BANLkTi=u6uROStb5geKYjfts_G6uqx+=-A@mail.gmail.com> (raw)
In-Reply-To: <20cf303f68baea326404a441da76@google.com>
On 5/27/11, dnovillo@google.com <dnovillo@google.com> wrote:
>
> http://codereview.appspot.com/4526083/diff/1/gcc/cp/cp-objcp-common.c
> File gcc/cp/cp-objcp-common.c (right):
>
> http://codereview.appspot.com/4526083/diff/1/gcc/cp/cp-objcp-common.c#newcode103
> gcc/cp/cp-objcp-common.c:103:
> case TEMPLATE_INFO: return sizeof (struct
> tree_template_info);
>
> + case TREE_BINFO: return sizeof (struct tree_binfo);
> +
>
>
> TREE_BINFO is not a C++ code and it's variably-sized. It is already
> handled by tree.c:tree_size()
>
> Not sure why you needed to add this here?
It appears on of the other fixes in that patch fixed the issue,
so I will remove this change.
>
> http://codereview.appspot.com/4526083/
>
--
Lawrence Crowl
next prev parent reply other threads:[~2011-05-27 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 14:12 dnovillo
2011-05-27 19:18 ` Lawrence Crowl [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-27 4:57 Lawrence Crowl
2011-05-27 6:11 ` Nathan Froyd
2011-05-27 19:09 ` Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=u6uROStb5geKYjfts_G6uqx+=-A@mail.gmail.com' \
--to=crowl@google.com \
--cc=dnovillo@google.com \
--cc=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).