From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16281 invoked by alias); 27 May 2011 17:58:02 -0000 Received: (qmail 16271 invoked by uid 22791); 27 May 2011 17:58:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_BJ,TW_JC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 17:57:47 +0000 Received: from kpbe14.cbf.corp.google.com (kpbe14.cbf.corp.google.com [172.25.105.78]) by smtp-out.google.com with ESMTP id p4RHvjNl016698 for ; Fri, 27 May 2011 10:57:45 -0700 Received: from pxi17 (pxi17.prod.google.com [10.243.27.17]) by kpbe14.cbf.corp.google.com with ESMTP id p4RHvajJ009941 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 27 May 2011 10:57:44 -0700 Received: by pxi17 with SMTP id 17so1226439pxi.20 for ; Fri, 27 May 2011 10:57:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.214.21 with SMTP id m21mr377110wfg.17.1306519063958; Fri, 27 May 2011 10:57:43 -0700 (PDT) Received: by 10.142.241.14 with HTTP; Fri, 27 May 2011 10:57:43 -0700 (PDT) In-Reply-To: <20cf303f68baea326404a441da76@google.com> References: <20cf303f68baea326404a441da76@google.com> Date: Fri, 27 May 2011 19:18:00 -0000 Message-ID: Subject: Re: [pph] More C++ Tree Nodes (issue4526083) From: Lawrence Crowl To: crowl@google.com, dnovillo@google.com, froydnj@codesourcery.com, gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg02196.txt.bz2 On 5/27/11, dnovillo@google.com wrote: > > http://codereview.appspot.com/4526083/diff/1/gcc/cp/cp-objcp-common.c > File gcc/cp/cp-objcp-common.c (right): > > http://codereview.appspot.com/4526083/diff/1/gcc/cp/cp-objcp-common.c#newcode103 > gcc/cp/cp-objcp-common.c:103: > case TEMPLATE_INFO: return sizeof (struct > tree_template_info); > > + case TREE_BINFO: return sizeof (struct tree_binfo); > + > > > TREE_BINFO is not a C++ code and it's variably-sized. It is already > handled by tree.c:tree_size() > > Not sure why you needed to add this here? It appears on of the other fixes in that patch fixed the issue, so I will remove this change. > > http://codereview.appspot.com/4526083/ > -- Lawrence Crowl