From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27519 invoked by alias); 13 Apr 2011 02:57:30 -0000 Received: (qmail 27508 invoked by uid 22791); 13 Apr 2011 02:57:29 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 02:57:25 +0000 Received: from hpaq1.eem.corp.google.com (hpaq1.eem.corp.google.com [172.25.149.1]) by smtp-out.google.com with ESMTP id p3D2vNSA001645 for ; Tue, 12 Apr 2011 19:57:24 -0700 Received: from gwj17 (gwj17.prod.google.com [10.200.10.17]) by hpaq1.eem.corp.google.com with ESMTP id p3D2upWB017794 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 12 Apr 2011 19:57:22 -0700 Received: by gwj17 with SMTP id 17so88159gwj.10 for ; Tue, 12 Apr 2011 19:57:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.114.6 with SMTP id m6mr79024ybc.184.1302663441797; Tue, 12 Apr 2011 19:57:21 -0700 (PDT) Received: by 10.150.212.19 with HTTP; Tue, 12 Apr 2011 19:57:21 -0700 (PDT) In-Reply-To: <20110413024341.GT23480@codesourcery.com> References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> <20110413024341.GT23480@codesourcery.com> Date: Wed, 13 Apr 2011 02:57:00 -0000 Message-ID: Subject: Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses From: Diego Novillo To: Nathan Froyd Cc: gcc-patches@gcc.gnu.org, iant@google.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00960.txt.bz2 On Tue, Apr 12, 2011 at 22:43, Nathan Froyd wrot= e: > On Thu, Mar 10, 2011 at 11:23:10PM -0500, Nathan Froyd wrote: >> Now that we have a structure where not every node might include >> TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said >> accessors that the argument is properly typed. =C2=A0This requires a num= ber >> of changes: > > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00565.html > > Ping. =C2=A0I was going to commit this, but I realized I hadn't received > approval for the go or LTO bits. =C2=A0They probably qualify as obvious, > given that they're exactly the same as all the other languages, but just > to rubber-stamp everything... > >> gcc/go/ >> =C2=A0 =C2=A0 =C2=A0 * go-lang.c (union lang_tree_node): Check for TS_CO= MMON before >> =C2=A0 =C2=A0 =C2=A0 calling TREE_CHAIN. >> >> gcc/lto/ >> =C2=A0 =C2=A0 =C2=A0 * lto-tree.h (union lang_tree_node): Check for TS_C= OMMON before >> =C2=A0 =C2=A0 =C2=A0 calling TREE_CHAIN. >> =C2=A0 =C2=A0 =C2=A0 * lto.c (lto_fixup_common): Likewise. OK. Diego.