From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23219 invoked by alias); 17 May 2011 03:13:30 -0000 Received: (qmail 23209 invoked by uid 22791); 17 May 2011 03:13:28 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-px0-f172.google.com (HELO mail-px0-f172.google.com) (209.85.212.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 May 2011 03:13:12 +0000 Received: by pxi6 with SMTP id 6so80126pxi.17 for ; Mon, 16 May 2011 20:13:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.69.14 with SMTP id a14mr263399pbu.292.1305601992048; Mon, 16 May 2011 20:13:12 -0700 (PDT) Received: by 10.68.43.65 with HTTP; Mon, 16 May 2011 20:13:12 -0700 (PDT) In-Reply-To: References: Date: Tue, 17 May 2011 07:16:00 -0000 Message-ID: Subject: Re: [PATCH, i386] PR 48743 Correctly detect AMD K6-2+ and K6-3+ From: Zuxy Meng To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=0015176f1862f441c704a370261c Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01183.txt.bz2 --0015176f1862f441c704a370261c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1481 2011/5/17 H.J. Lu : > On Mon, May 16, 2011 at 7:41 PM, Zuxy Meng wrote: >> 2011/5/16 H.J. Lu : >>> On Sun, May 15, 2011 at 10:03 PM, Zuxy Meng wrote: >>>> Misdetected as Athlon by GCC, K6-2+ and K6-3+ are processors that supp= ort >>>> extended 3DNow! but don't support extended MMX or CMOV. >>>> >>>> I don't own a K6-2 or Athlon machine. Can anybody have the patch teste= d? >>>> >>>> 2011-05-16 Zuxy Meng >>>> PR i386/48743 >>>> * config/i386/cpuid.h (bit_MMXEXT): New >>>> * config/i386/cpuid.h (bit_3DNOWP): Deleted >>> >>> Why do you remove bit_3DNOWP? is a public header file. >> >> Because this bit was added to detect Athlon and not used elsewhere. > > The first part might be true and the second part is false. =A0Since > is a public header file, it may be used in any software > packages. > >> cpuid.h doesn't define all the feature bits available in the output of >> CPUID instruction so I thought only the actually used bits are to be >> included. > > That is false. I would appreciate a patch to define all feature bits. OK. Resending patch. 2011-05-16 Zuxy Meng PR i386/48743 * config/i386/cpuid.h (bit_MMXEXT): New * config/i386/driver-i386.c (host_detect_local_cpu): Detect Athlon by the presence of extended MMX instead of extended 3DNow! --=20 Zuxy Beauty is truth, While truth is beauty. PGP KeyID: E8555ED6 --0015176f1862f441c704a370261c Content-Type: application/octet-stream; name="k6-3+.diff" Content-Disposition: attachment; filename="k6-3+.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gns9p2ei0 Content-length: 1826 LS0tIGNwdWlkLmgub3JpZwkyMDEwLTExLTExIDA2OjAyOjM0ICswODAwDQor KysgY3B1aWQuaAkyMDExLTA1LTE3IDExOjA4OjE0ICswODAwDQpAQCAtNTcs NiArNTcsNyBAQA0KICNkZWZpbmUgYml0X1RCTSAgICAgICAgICgxIDw8IDIx KQ0KIA0KIC8qICVlZHggKi8NCisjZGVmaW5lIGJpdF9NTVhFWFQJKDEgPDwg MjIpDQogI2RlZmluZSBiaXRfTE0JCSgxIDw8IDI5KQ0KICNkZWZpbmUgYml0 XzNETk9XUAkoMSA8PCAzMCkNCiAjZGVmaW5lIGJpdF8zRE5PVwkoMSA8PCAz MSkNCi0tLSBkcml2ZXItaTM4Ni5jLm9yaWcJMjAxMS0wNS0xMiAxNjoxMzo0 NyArMDgwMA0KKysrIGRyaXZlci1pMzg2LmMJMjAxMS0wNS0xMiAxNjoyMToz OSArMDgwMA0KQEAgLTM5MSw3ICszOTEsNyBAQA0KIA0KICAgLyogRXh0ZW5k ZWQgZmVhdHVyZXMgKi8NCiAgIHVuc2lnbmVkIGludCBoYXNfbGFoZl9sbSA9 IDAsIGhhc19zc2U0YSA9IDA7DQotICB1bnNpZ25lZCBpbnQgaGFzX2xvbmdt b2RlID0gMCwgaGFzXzNkbm93cCA9IDAsIGhhc18zZG5vdyA9IDA7DQorICB1 bnNpZ25lZCBpbnQgaGFzX21teGV4dCA9IDAsIGhhc19sb25nbW9kZSA9IDAs IGhhc18zZG5vdyA9IDA7DQogICB1bnNpZ25lZCBpbnQgaGFzX21vdmJlID0g MCwgaGFzX3NzZTRfMSA9IDAsIGhhc19zc2U0XzIgPSAwOw0KICAgdW5zaWdu ZWQgaW50IGhhc19wb3BjbnQgPSAwLCBoYXNfYWVzID0gMCwgaGFzX2F2eCA9 IDA7DQogICB1bnNpZ25lZCBpbnQgaGFzX3BjbG11bCA9IDAsIGhhc19hYm0g PSAwLCBoYXNfbHdwID0gMDsNCkBAIC00NjUsOCArNDY1LDggQEANCiAgICAg ICBoYXNfeG9wID0gZWN4ICYgYml0X1hPUDsNCiAgICAgICBoYXNfdGJtID0g ZWN4ICYgYml0X1RCTTsNCiANCisgICAgICBoYXNfbW14ZXh0ID0gZWR4ICYg Yml0X01NWEVYVDsNCiAgICAgICBoYXNfbG9uZ21vZGUgPSBlZHggJiBiaXRf TE07DQotICAgICAgaGFzXzNkbm93cCA9IGVkeCAmIGJpdF8zRE5PV1A7DQog ICAgICAgaGFzXzNkbm93ID0gZWR4ICYgYml0XzNETk9XOw0KIA0KICAgICAg IF9fY3B1aWQgKDB4NywgZWF4LCBlYngsIGVjeCwgZWR4KTsNCkBAIC01MDYs NyArNTA2LDcgQEANCiAJcHJvY2Vzc29yID0gUFJPQ0VTU09SX0FNREZBTTEw Ow0KICAgICAgIGVsc2UgaWYgKGhhc19zc2UyIHx8IGhhc19sb25nbW9kZSkN CiAJcHJvY2Vzc29yID0gUFJPQ0VTU09SX0s4Ow0KLSAgICAgIGVsc2UgaWYg KGhhc18zZG5vd3ApDQorICAgICAgZWxzZSBpZiAoaGFzX21teGV4dCkNCiAJ cHJvY2Vzc29yID0gUFJPQ0VTU09SX0FUSExPTjsNCiAgICAgICBlbHNlIGlm IChoYXNfbW14KQ0KIAlwcm9jZXNzb3IgPSBQUk9DRVNTT1JfSzY7DQo= --0015176f1862f441c704a370261c--