From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-295530-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 21606 invoked by alias); 29 Jun 2011 10:05:02 -0000
Received: (qmail 21586 invoked by uid 22791); 29 Jun 2011 10:05:00 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-ew0-f47.google.com (HELO mail-ew0-f47.google.com) (209.85.215.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jun 2011 10:04:45 +0000
Received: by ewy5 with SMTP id 5so412438ewy.20        for <gcc-patches@gcc.gnu.org>; Wed, 29 Jun 2011 03:04:43 -0700 (PDT)
Received: by 10.14.37.197 with SMTP id y45mr172596eea.26.1309341882126; Wed, 29 Jun 2011 03:04:42 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.14.28.208 with HTTP; Wed, 29 Jun 2011 03:04:22 -0700 (PDT)
In-Reply-To: <4E0ADBEF.1040005@gjlay.de>
References: <4DFF4EFE.3080006@gjlay.de> <4E09B29D.50809@gjlay.de> <BANLkTik8UOyxKi3LWFXX3W9y32KhCx2FvA@mail.gmail.com> <4E0ADBEF.1040005@gjlay.de>
From: Denis Chertykov <chertykov@gmail.com>
Date: Wed, 29 Jun 2011 10:42:00 -0000
Message-ID: <BANLkTik0y85OLjjsC0-_ES4HvVaGOGGWUA@mail.gmail.com>
Subject: Re: Ping #1: [Patch, AVR]: Fix PR34734
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches@gcc.gnu.org, "Eric B. Weddington" <eric.weddington@atmel.com>, 	Anatoly Sokolov <aesok@post.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-06/txt/msg02215.txt.bz2

2011/6/29 Georg-Johann Lay <avr@gjlay.de>:
> Denis Chertykov wrote:
>> 2011/6/28 Georg-Johann Lay <avr@gjlay.de>:
>>> http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01462.html
>>>
>>> Georg-Johann Lay wrote:
>>>> PR34734 produces annoying, false warnings if __attribute__((progmem))
>>>> is used in conjunction with C++. =C2=A0DECL_INITIAL is not yet set up =
in
>>>> avr_handle_progmem_attribute.
>>>>
>>>> Johann
>>>>
>>>> =C2=A0 =C2=A0 =C2=A0 PR target/34734
>>>> =C2=A0 =C2=A0 =C2=A0 * config/avr/avr.c (avr_handle_progmem_attribute)=
: Move warning
>>>> =C2=A0 =C2=A0 =C2=A0 about uninitialized data attributed 'progmem' fro=
m here...
>>>> =C2=A0 =C2=A0 =C2=A0 (avr_encode_section_info): ...to this new functio=
n.
>>>> =C2=A0 =C2=A0 =C2=A0 (TARGET_ENCODE_SECTION_INFO): New define.
>>>> =C2=A0 =C2=A0 =C2=A0 (avr_section_type_flags): For data in ".progmem.d=
ata", remove
>>>> =C2=A0 =C2=A0 =C2=A0 section flag SECTION_WRITE.
>>> avr_encode_section_info is good place to emit the warning:
>>> DECL_INITIAL has stabilized for C++, the warning will appear even for
>>> unused variables that will eventually be thrown away, and the warning
>>> appears only once (new_decl_p).
>>
>> Approved.
>>
>> Denis.
>
> Is this a patch that should be backported?
> 4.6?
> 4.5?
>
> It's not fix for "bug or doc" but very annoying, false warning.

You can backport it if you want.

I'm usually didn't backport such patches.

Denis.