From: Diego Novillo <dnovillo@google.com>
To: Gabriel Charette <gchare@google.com>
Cc: reply@codereview.appspotmail.com, crowl@google.com,
gcc-patches@gcc.gnu.org
Subject: Re: [pph] Add header files to pph.map (issue4639073)
Date: Mon, 27 Jun 2011 17:10:00 -0000 [thread overview]
Message-ID: <BANLkTik1Skz-TiLcegD97Xv1QoyNpzFqAQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikKkRjBi4EuvQcO4tVLbAFaf3mbnx+J6-nqdsZwmu6a2Q@mail.gmail.com>
On Mon, Jun 27, 2011 at 13:01, Gabriel Charette <gchare@google.com> wrote:
> Couldn't we have headers look for their corresponding .pph file by
> default when -fpph-map is on? (especially since pph.map is only
> temporary for the implementation phase)
The problem is with headers that include other headers. We want to
limit the generation of images to specific headers. Given that we are
in this initial implementation phase, the simplest approach is to
remember to update pph.map.
> Could that also be why the small test I tried to introduce last week
> to test the ordering of the bindings coming from the pph would pass
> (i.e. it wouldn't use it's pph as I didn't add it to pph.map?).
Yes, that's likely.
Diego.
next prev parent reply other threads:[~2011-06-27 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 16:48 Diego Novillo
2011-06-27 17:06 ` Gabriel Charette
2011-06-27 17:10 ` Diego Novillo [this message]
2011-06-27 17:30 ` Gabriel Charette
2011-06-27 17:34 ` Diego Novillo
2011-06-27 17:53 ` Gabriel Charette
2011-06-27 19:24 ` Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik1Skz-TiLcegD97Xv1QoyNpzFqAQ@mail.gmail.com \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gchare@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).