* [google] Install cpu_defines.h (issue4440044)
@ 2011-04-16 22:11 Diego Novillo
2011-04-19 16:38 ` Benjamin Kosnik
2011-04-19 17:38 ` Doug Kwan (關振德)
0 siblings, 2 replies; 6+ messages in thread
From: Diego Novillo @ 2011-04-16 22:11 UTC (permalink / raw)
To: reply, dougkwan, libstdc++, gcc-patches
I am committing this patch from Doug Kwan on google/main.
This patch adds cpu_defines.h to the set of files to be installed.
Doug, could you describe why we need to do this? Will you be
submitting this patch for trunk?
Tested on x86_64. Committed on google/main.
Diego.
2011-03-15 Doug Kwan <dougkwan@google.com>
Google ref 50044.
PR libstdc++/48123
* include/Makefile.am (install-freestanding-headers): Install
cpu_defines.h
* include/Makefile.in: Regenerate.
diff --git a/libstdc++-v3/include/Makefile.am b/libstdc++-v3/include/Makefile.am
index e7f1543..d3b44bc 100644
--- a/libstdc++-v3/include/Makefile.am
+++ b/libstdc++-v3/include/Makefile.am
@@ -1201,7 +1201,8 @@ endif
install-freestanding-headers:
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
$(mkinstalldirs) $(DESTDIR)${host_installdir}
- for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h; do \
+ for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
+ ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
$(INSTALL_DATA) ${std_builddir}/limits $(DESTDIR)${gxx_include_dir}/${std_builddir}
diff --git a/libstdc++-v3/include/Makefile.in b/libstdc++-v3/include/Makefile.in
index a93b2ea..8a23c1b 100644
--- a/libstdc++-v3/include/Makefile.in
+++ b/libstdc++-v3/include/Makefile.in
@@ -1585,7 +1585,8 @@ ${pch3_output}: ${pch3_source} ${pch2_output}
install-freestanding-headers:
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
$(mkinstalldirs) $(DESTDIR)${host_installdir}
- for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h; do \
+ for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
+ ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
$(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
$(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
$(INSTALL_DATA) ${std_builddir}/limits $(DESTDIR)${gxx_include_dir}/${std_builddir}
--
This patch is available for review at http://codereview.appspot.com/4440044
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [google] Install cpu_defines.h (issue4440044)
2011-04-16 22:11 [google] Install cpu_defines.h (issue4440044) Diego Novillo
@ 2011-04-19 16:38 ` Benjamin Kosnik
2011-04-19 16:42 ` Diego Novillo
2011-04-19 17:38 ` Doug Kwan (關振德)
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Kosnik @ 2011-04-19 16:38 UTC (permalink / raw)
To: Diego Novillo; +Cc: reply, dougkwan, libstdc++, gcc-patches
> This patch adds cpu_defines.h to the set of files to be installed.
> Doug, could you describe why we need to do this? Will you be
> submitting this patch for trunk?
It's already in trunk, see
2011-03-15 Doug Kwan <dougkwan@google.com>
PR libstdc++/48123
* include/Makefile.am (install-freestanding-headers): Install
cpu_defines.h
* include/Makefile.in: Regenerate.
-benjamin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [google] Install cpu_defines.h (issue4440044)
2011-04-19 16:38 ` Benjamin Kosnik
@ 2011-04-19 16:42 ` Diego Novillo
0 siblings, 0 replies; 6+ messages in thread
From: Diego Novillo @ 2011-04-19 16:42 UTC (permalink / raw)
To: Benjamin Kosnik; +Cc: reply, dougkwan, libstdc++, gcc-patches
On Tue, Apr 19, 2011 at 12:04, Benjamin Kosnik <bkoz@redhat.com> wrote:
>
>> This patch adds cpu_defines.h to the set of files to be installed.
>> Doug, could you describe why we need to do this? Will you be
>> submitting this patch for trunk?
>
> It's already in trunk, see
D'oh. Thanks. Clearly, I was no autopilot. Doug even said so in the
internal patch tracking tool.
Diego.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [google] Install cpu_defines.h (issue4440044)
2011-04-16 22:11 [google] Install cpu_defines.h (issue4440044) Diego Novillo
2011-04-19 16:38 ` Benjamin Kosnik
@ 2011-04-19 17:38 ` Doug Kwan (關振德)
2011-04-19 17:49 ` Paolo Carlini
1 sibling, 1 reply; 6+ messages in thread
From: Doug Kwan (關振德) @ 2011-04-19 17:38 UTC (permalink / raw)
To: Diego Novillo; +Cc: reply, libstdc++, gcc-patches
This is used for a freestanding C++ library (i.e., we build
libsupc++.a only). This is in trunk but for some reason it is not in
the 4.6 release.
-Doug
On Sat, Apr 16, 2011 at 1:27 PM, Diego Novillo <dnovillo@google.com> wrote:
> I am committing this patch from Doug Kwan on google/main.
>
> This patch adds cpu_defines.h to the set of files to be installed.
> Doug, could you describe why we need to do this? Will you be
> submitting this patch for trunk?
>
> Tested on x86_64. Committed on google/main.
>
>
> Diego.
>
> 2011-03-15 Doug Kwan <dougkwan@google.com>
>
> Google ref 50044.
>
> PR libstdc++/48123
> * include/Makefile.am (install-freestanding-headers): Install
> cpu_defines.h
> * include/Makefile.in: Regenerate.
>
> diff --git a/libstdc++-v3/include/Makefile.am b/libstdc++-v3/include/Makefile.am
> index e7f1543..d3b44bc 100644
> --- a/libstdc++-v3/include/Makefile.am
> +++ b/libstdc++-v3/include/Makefile.am
> @@ -1201,7 +1201,8 @@ endif
> install-freestanding-headers:
> $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
> $(mkinstalldirs) $(DESTDIR)${host_installdir}
> - for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h; do \
> + for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
> + ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
> $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
> $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
> $(INSTALL_DATA) ${std_builddir}/limits $(DESTDIR)${gxx_include_dir}/${std_builddir}
> diff --git a/libstdc++-v3/include/Makefile.in b/libstdc++-v3/include/Makefile.in
> index a93b2ea..8a23c1b 100644
> --- a/libstdc++-v3/include/Makefile.in
> +++ b/libstdc++-v3/include/Makefile.in
> @@ -1585,7 +1585,8 @@ ${pch3_output}: ${pch3_source} ${pch2_output}
> install-freestanding-headers:
> $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}
> $(mkinstalldirs) $(DESTDIR)${host_installdir}
> - for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h; do \
> + for file in ${host_srcdir}/os_defines.h ${host_builddir}/c++config.h \
> + ${glibcxx_srcdir}/$(CPU_DEFINES_SRCDIR)/cpu_defines.h; do \
> $(INSTALL_DATA) $${file} $(DESTDIR)${host_installdir}; done
> $(mkinstalldirs) $(DESTDIR)${gxx_include_dir}/${std_builddir}
> $(INSTALL_DATA) ${std_builddir}/limits $(DESTDIR)${gxx_include_dir}/${std_builddir}
>
>
> --
> This patch is available for review at http://codereview.appspot.com/4440044
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [google] Install cpu_defines.h (issue4440044)
2011-04-19 17:38 ` Doug Kwan (關振德)
@ 2011-04-19 17:49 ` Paolo Carlini
2011-04-19 18:20 ` Doug Kwan (關振德)
0 siblings, 1 reply; 6+ messages in thread
From: Paolo Carlini @ 2011-04-19 17:49 UTC (permalink / raw)
To: "Doug Kwan (關振德)"
Cc: Diego Novillo, reply, libstdc++, gcc-patches
On 04/19/2011 07:26 PM, Doug Kwan (關振德) wrote:
> This is used for a freestanding C++ library (i.e., we build
> libsupc++.a only). This is in trunk but for some reason it is not in
> the 4.6 release.
Why do you think so? For sure upon approval you committed it to the
branch too, on March, 15th.
Paolo.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [google] Install cpu_defines.h (issue4440044)
2011-04-19 17:49 ` Paolo Carlini
@ 2011-04-19 18:20 ` Doug Kwan (關振德)
0 siblings, 0 replies; 6+ messages in thread
From: Doug Kwan (關振德) @ 2011-04-19 18:20 UTC (permalink / raw)
To: Paolo Carlini; +Cc: Diego Novillo, reply, libstdc++, gcc-patches
My bad. I looked at the gcc-4.6.0 tarball and it is indeed there.
-Doug
On Tue, Apr 19, 2011 at 10:36 AM, Paolo Carlini
<paolo.carlini@oracle.com> wrote:
> On 04/19/2011 07:26 PM, Doug Kwan (關振德) wrote:
>>
>> This is used for a freestanding C++ library (i.e., we build
>> libsupc++.a only). This is in trunk but for some reason it is not in
>> the 4.6 release.
>
> Why do you think so? For sure upon approval you committed it to the branch
> too, on March, 15th.
>
> Paolo.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-19 18:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-16 22:11 [google] Install cpu_defines.h (issue4440044) Diego Novillo
2011-04-19 16:38 ` Benjamin Kosnik
2011-04-19 16:42 ` Diego Novillo
2011-04-19 17:38 ` Doug Kwan (關振德)
2011-04-19 17:49 ` Paolo Carlini
2011-04-19 18:20 ` Doug Kwan (關振德)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).