* Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS
@ 2011-04-07 19:42 Basile Starynkevitch
2011-04-07 19:44 ` Basile Starynkevitch
0 siblings, 1 reply; 6+ messages in thread
From: Basile Starynkevitch @ 2011-04-07 19:42 UTC (permalink / raw)
To: gcc-patches
Hello All,
The following tiny patch add some files to PLUGIN_HEADERS.
Since they are missing in 4.6, I had to copy them in the MELT plugin
tar ball release candidate 0.
##### tiny patch to trunk 172124
Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in (revision 172124)
+++ gcc/Makefile.in (working copy)
@@ -4534,6 +4534,7 @@
$(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \
$(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h
tree-inline.h \
+ gimple-pretty-print.h tree-pretty-print.h realmpfr.h \
$(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
# generate the 'build fragment' b-header-vars
###### gcc/ChangeLog entry
2011-04-07 Basile Starynkevitch <basile@starynkevitch.net>
* Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
tree-pretty-print.h & realmpfr.h.
######
Some more explanations about why I feel these files are badly needed
for plugins (not only for MELT as a plugin, but for other plugins).
Pretty printing routines are very useful to help understand, debug, and
dump any additional passes, so plugin providing passes working on
Gimple or Tree need the gimple-pretty-print.h & tree-pretty-print.h,
since to call dumping or debug routines like debug_c_tree or
print_declaration or dump_gimple_stmt you need to include these files.
Please consider that people coding plugins know Gimple & Tree much
less than GCC top level experts, and they are much more likely to
need debug or dumping routines!
The realmpfr.h file is needed to operate on tree or gimple containing
real constants. For instance, a plugin to find all occurrences (in
Gimple) of 3.14159 need it, or also a plugin which constant-fold the
calls to <math.h> which are not already constant folded in GCC, or a
plugin which constant-fold calls to some other (but less standard)
numerical library.
Ok for trunk?
Cheers.
PS. If I am lucky enough to have this patch accepted for trunk,
I might even later consider proposing to backport it to gcc 4.6.1.
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS
2011-04-07 19:42 Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS Basile Starynkevitch
@ 2011-04-07 19:44 ` Basile Starynkevitch
2011-04-11 19:25 ` Ping " Basile Starynkevitch
0 siblings, 1 reply; 6+ messages in thread
From: Basile Starynkevitch @ 2011-04-07 19:44 UTC (permalink / raw)
To: Basile Starynkevitch; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Thu, 7 Apr 2011 21:41:18 +0200
Basile Starynkevitch <basile@starynkevitch.net> wrote:
>
> Hello All,
>
> The following tiny patch add some files to PLUGIN_HEADERS.
> Since they are missing in 4.6, I had to copy them in the MELT plugin
> tar ball release candidate 0.
Sorry, my mailer wrapped the patch in line. I am attaching it here.
Cheers
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
[-- Attachment #2: plugin-headers-gcc-r172124.diff --]
[-- Type: text/x-diff, Size: 556 bytes --]
Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in (revision 172124)
+++ gcc/Makefile.in (working copy)
@@ -4534,6 +4534,7 @@
$(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \
$(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
+ gimple-pretty-print.h tree-pretty-print.h realmpfr.h \
$(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
# generate the 'build fragment' b-header-vars
^ permalink raw reply [flat|nested] 6+ messages in thread
* Ping Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS
2011-04-07 19:44 ` Basile Starynkevitch
@ 2011-04-11 19:25 ` Basile Starynkevitch
2011-04-11 19:27 ` Diego Novillo
0 siblings, 1 reply; 6+ messages in thread
From: Basile Starynkevitch @ 2011-04-11 19:25 UTC (permalink / raw)
To: dnovillo; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]
On Thu, 7 Apr 2011 21:43:44 +0200
Basile Starynkevitch <basile@starynkevitch.net> wrote:
> > The following tiny patch add some files to PLUGIN_HEADERS.
###### gcc/ChangeLog entry
2011-04-11 Basile Starynkevitch <basile@starynkevitch.net>
* Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
tree-pretty-print.h & realmpfr.h.
######
> Some more explanations about why I feel these files are badly needed
> for plugins (not only for MELT as a plugin, but for other plugins).
>
> Pretty printing routines are very useful to help understand, debug, and
> dump any additional passes, so plugin providing passes working on
> Gimple or Tree need the gimple-pretty-print.h & tree-pretty-print.h,
> since to call dumping or debug routines like debug_c_tree or
> print_declaration or dump_gimple_stmt you need to include these files.
> Please consider that people coding plugins know Gimple & Tree much
> less than GCC top level experts, and they are much more likely to
> need debug or dumping routines!
>
> The realmpfr.h file is needed to operate on tree or gimple containing
> real constants. For instance, a plugin to find all occurrences (in
> Gimple) of 3.14159 need it, or also a plugin which constant-fold the
> calls to <math.h> which are not already constant folded in GCC, or a
> plugin which constant-fold calls to some other (but less standard)
> numerical library.
Ok for trunk?
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
[-- Attachment #2: plugin-headers-gcc-r172124.diff --]
[-- Type: text/x-diff, Size: 556 bytes --]
Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in (revision 172124)
+++ gcc/Makefile.in (working copy)
@@ -4534,6 +4534,7 @@
$(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \
$(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
+ gimple-pretty-print.h tree-pretty-print.h realmpfr.h \
$(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
# generate the 'build fragment' b-header-vars
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Ping Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS
2011-04-11 19:25 ` Ping " Basile Starynkevitch
@ 2011-04-11 19:27 ` Diego Novillo
2011-04-11 19:33 ` Basile Starynkevitch
0 siblings, 1 reply; 6+ messages in thread
From: Diego Novillo @ 2011-04-11 19:27 UTC (permalink / raw)
To: Basile Starynkevitch; +Cc: gcc-patches
On Mon, Apr 11, 2011 at 15:24, Basile Starynkevitch
<basile@starynkevitch.net> wrote:
> 2011-04-11 Basile Starynkevitch <basile@starynkevitch.net>
> * Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
> tree-pretty-print.h & realmpfr.h.
OK.
Diego.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Ping Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS
2011-04-11 19:27 ` Diego Novillo
@ 2011-04-11 19:33 ` Basile Starynkevitch
2011-04-11 19:34 ` Diego Novillo
0 siblings, 1 reply; 6+ messages in thread
From: Basile Starynkevitch @ 2011-04-11 19:33 UTC (permalink / raw)
To: Diego Novillo; +Cc: gcc-patches
On Mon, 11 Apr 2011 15:27:15 -0400
Diego Novillo <dnovillo@google.com> wrote:
> On Mon, Apr 11, 2011 at 15:24, Basile Starynkevitch
> <basile@starynkevitch.net> wrote:
>
> > 2011-04-11 Basile Starynkevitch <basile@starynkevitch.net>
> > * Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
> > tree-pretty-print.h & realmpfr.h.
>
> OK.
Committed revision 172275.
Thanks. I would like to also commit that same patch to gcc-4.6 for the next 4.6.1 release. Is that possible?
Cheers.
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Ping Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS
2011-04-11 19:33 ` Basile Starynkevitch
@ 2011-04-11 19:34 ` Diego Novillo
0 siblings, 0 replies; 6+ messages in thread
From: Diego Novillo @ 2011-04-11 19:34 UTC (permalink / raw)
To: Basile Starynkevitch; +Cc: gcc-patches
On Mon, Apr 11, 2011 at 15:31, Basile Starynkevitch
<basile@starynkevitch.net> wrote:
> On Mon, 11 Apr 2011 15:27:15 -0400
> Diego Novillo <dnovillo@google.com> wrote:
>
>> On Mon, Apr 11, 2011 at 15:24, Basile Starynkevitch
>> <basile@starynkevitch.net> wrote:
>>
>> > 2011-04-11 Basile Starynkevitch <basile@starynkevitch.net>
>> > * Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
>> > tree-pretty-print.h & realmpfr.h.
>>
>> OK.
>
> Committed revision 172275.
>
>
> Thanks. I would like to also commit that same patch to gcc-4.6 for the next 4.6.1 release. Is that possible?
I'm fine with that, but I cannot approve. You need one of our RMs to
approve that.
Diego.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-11 19:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-07 19:42 Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS Basile Starynkevitch
2011-04-07 19:44 ` Basile Starynkevitch
2011-04-11 19:25 ` Ping " Basile Starynkevitch
2011-04-11 19:27 ` Diego Novillo
2011-04-11 19:33 ` Basile Starynkevitch
2011-04-11 19:34 ` Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).