From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17185 invoked by alias); 12 Jun 2011 13:18:52 -0000 Received: (qmail 17175 invoked by uid 22791); 12 Jun 2011 13:18:51 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Jun 2011 13:18:33 +0000 Received: by qwh5 with SMTP id 5so2117296qwh.20 for ; Sun, 12 Jun 2011 06:18:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.106.34 with SMTP id v34mr3057444qco.111.1307884711809; Sun, 12 Jun 2011 06:18:31 -0700 (PDT) Received: by 10.229.47.78 with HTTP; Sun, 12 Jun 2011 06:18:31 -0700 (PDT) In-Reply-To: References: <20110611150953.GA18253@intel.com> Date: Sun, 12 Jun 2011 13:35:00 -0000 Message-ID: Subject: Re: PATCH [1/n]: Prepare x32: PR middle-end/47364: internal compiler error: in emit_move_insn, at expr.c:3355 From: "H.J. Lu" To: Richard Guenther Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00937.txt.bz2 On Sun, Jun 12, 2011 at 3:48 AM, Richard Guenther wrote: > On Sat, Jun 11, 2011 at 5:09 PM, H.J. Lu wrote: >> Hi, >> >> expand_builtin_strlen has >> >> src_reg =3D gen_reg_rtx (Pmode); >> ... >> pat =3D expand_expr (src, src_reg, ptr_mode, EXPAND_NORMAL); >> if (pat !=3D src_reg) >> =A0emit_move_insn (src_reg, pat); >> >> But src_reg may be in ptr_mode, wich may not be the same as Pmode. >> This patch checks it. =A0OK for trunk? >> >> Thanks. >> >> >> H.J. >> --- >> 2011-06-11 =A0H.J. Lu =A0 >> >> =A0 =A0 =A0 =A0PR middle-end/47364 >> =A0 =A0 =A0 =A0* builtins.c (expand_builtin_strlen): Properly handle tar= get >> =A0 =A0 =A0 =A0not in Pmode. >> >> diff --git a/gcc/builtins.c b/gcc/builtins.c >> index 7b24a0c..4e2cf31 100644 >> --- a/gcc/builtins.c >> +++ b/gcc/builtins.c >> @@ -2941,7 +2941,11 @@ expand_builtin_strlen (tree exp, rtx target, >> =A0 =A0 =A0 start_sequence (); >> =A0 =A0 =A0 pat =3D expand_expr (src, src_reg, ptr_mode, EXPAND_NORMAL); >> =A0 =A0 =A0 if (pat !=3D src_reg) >> - =A0 =A0 =A0 emit_move_insn (src_reg, pat); >> + =A0 =A0 =A0 { >> + =A0 =A0 =A0 =A0 if (GET_MODE (pat) !=3D Pmode) >> + =A0 =A0 =A0 =A0 =A0 pat =3D convert_to_mode (Pmode, pat, 1); > > Shouldn't this be POINTERS_EXTEND_UNSIGNED instead of 1? > >> + =A0 =A0 =A0 =A0 emit_move_insn (src_reg, pat); > > Why not use convert_move unconditionally? > > Or, why not expand src in Pmode from the start? =A0After all, src_reg is > created as Pmode reg. > This patch works for my testcase. OK for trunk? Thanks. --=20 H.J. ---- 2011-06-12 H.J. Lu PR middle-end/47364 * builtins.c (expand_builtin_strlen): Expand strlen to Pmode. diff --git a/gcc/builtins.c b/gcc/builtins.c index 7b24a0c..7db4e6d 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -2939,7 +2939,7 @@ expand_builtin_strlen (tree exp, rtx target, /* Now that we are assured of success, expand the source. */ start_sequence (); - pat =3D expand_expr (src, src_reg, ptr_mode, EXPAND_NORMAL); + pat =3D expand_expr (src, src_reg, Pmode, EXPAND_NORMAL); if (pat !=3D src_reg) emit_move_insn (src_reg, pat); pat =3D get_insns ();