From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-294477-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 23619 invoked by alias); 15 Jun 2011 14:37:03 -0000
Received: (qmail 23379 invoked by uid 22791); 15 Jun 2011 14:37:02 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST
X-Spam-Check-By: sourceware.org
Received: from mail-qy0-f182.google.com (HELO mail-qy0-f182.google.com) (209.85.216.182)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Jun 2011 14:36:47 +0000
Received: by qyk27 with SMTP id 27so251301qyk.20        for <gcc-patches@gcc.gnu.org>; Wed, 15 Jun 2011 07:36:46 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.106.34 with SMTP id v34mr506556qco.111.1308148605648; Wed, 15 Jun 2011 07:36:45 -0700 (PDT)
Received: by 10.229.47.78 with HTTP; Wed, 15 Jun 2011 07:36:45 -0700 (PDT)
In-Reply-To: <Pine.LNX.4.64.1106151607290.17115@wotan.suse.de>
References: <20110611160548.GA20036@intel.com>	<Pine.LNX.4.64.1106151607290.17115@wotan.suse.de>
Date: Wed, 15 Jun 2011 15:10:00 -0000
Message-ID: <BANLkTik8Mz9WRhQGmoium5KGiiLAUgxUjg@mail.gmail.com>
Subject: Re: PATCH [5/n]: Prepare x32: PR middle-end/48016: Inconsistency in non-local goto save area
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Michael Matz <matz@suse.de>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-06/txt/msg01162.txt.bz2

On Wed, Jun 15, 2011 at 7:11 AM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Sat, 11 Jun 2011, H.J. Lu wrote:
>
>> We are very inconsistent when saving and restoring non-local goto save
>> area. =A0See:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D48016
>>
>> for detailed analysis. =A0OK for trunk?
>> + =A0/* FIXME: update_nonlocal_goto_save_area may pass SA in the wrong m=
ode. =A0*/
>> + =A0if (GET_MODE (sa) !=3D mode)
>> + =A0 =A0{
>> + =A0 =A0 =A0gcc_assert (ptr_mode !=3D Pmode
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 && GET_MODE (sa) =3D=3D ptr_mode
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 && mode =3D=3D Pmode);
>> + =A0 =A0 =A0sa =3D adjust_address (sa, mode, 0);
>> + =A0 =A0}
>
> That may be appropriate for a branch, but trunk shouldn't contain FIXMEs
> that explain how something should be fixed, instead that something should
> be carried out. =A0I.e. just fix update_nonlocal_goto_save_area.
>

I don't know update_nonlocal_goto_save_area enough to fix it
without breaking other targets.  This patch is the lest invasive.
Any suggestions how to properly fix it is appreciated.

Thanks.

--=20
H.J.