From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ira Rosen <ira.rosen@linaro.org>
Cc: gcc-patches@gcc.gnu.org, Patch Tracking <patches@linaro.org>
Subject: Re: [patch] Improve detection of widening multiplication in the vectorizer
Date: Tue, 07 Jun 2011 21:08:00 -0000 [thread overview]
Message-ID: <BANLkTikC14vNA7X2s-M2AnRDnFkqQk+5wA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=wUC7Lf2oqY3Gt4m8s0JfwbcJ78Q@mail.gmail.com>
On Wed, Jun 1, 2011 at 2:23 AM, Ira Rosen <ira.rosen@linaro.org> wrote:
> Hi,
>
> The vectorizer expects widening multiplication pattern to be:
>
> type a_t, b_t;
> TYPE a_T, b_T, prod_T;
>
> a_T = (TYPE) a_t;
> b_T = (TYPE) b_t;
> prod_T = a_T * b_T;
>
> where type 'TYPE' is double the size of type 'type'. This works fine
> when the types are signed. For the unsigned types the code looks like:
>
> unsigned type a_t, b_t;
> unsigned TYPE u_prod_T;
> TYPE a_T, b_T, prod_T;
>
> a_T = (TYPE) a_t;
> b_T = (TYPE) b_t;
> prod_T = a_T * b_T;
> u_prod_T = (unsigned TYPE) prod_T;
>
> i.e., the multiplication is done on signed, followed by a cast to unsigned.
> This patch adds a support of such patterns and generates
> WIDEN_MULT_EXPR for the unsigned type.
>
> Another unsupported case is multiplication by a constant (e.g., b_T is
> a constant). This patch checks that the constant fits the smaller type
> 'type' and recognizes such cases as widening multiplication.
>
> Bootstrapped and tested on powerpc64-suse-linux. Tested the
> vectorization testsuite on arm-linux-gnueabi.
> I'll commit the patch shortly if there are no comments/objections.
>
> Ira
>
> ChangeLog:
>
> * tree-vectorizer.h (vect_recog_func_ptr): Make last argument to be
> a pointer.
> * tree-vect-patterns.c (vect_recog_widen_sum_pattern,
> vect_recog_widen_mult_pattern, vect_recog_dot_prod_pattern,
> vect_recog_pow_pattern): Likewise.
> (vect_pattern_recog_1): Remove declaration.
> (widened_name_p): Remove declaration. Add new argument to specify
> whether to check that both types are either signed or unsigned.
> (vect_recog_widen_mult_pattern): Update documentation. Handle
> unsigned patterns and multiplication by constants.
> (vect_pattern_recog_1): Update vect_recog_func references. Use
> statement information from the statement returned from pattern
> detection functions.
> (vect_pattern_recog): Update vect_recog_func reference.
> * tree-vect-stmts.c (vectorizable_type_promotion): For widening
> multiplication by a constant use the type of the other operand.
>
.
This caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49318
--
H.J.
next prev parent reply other threads:[~2011-06-07 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 9:23 Ira Rosen
2011-06-01 9:42 ` Richard Guenther
2011-06-01 11:37 ` Ira Rosen
2011-06-01 12:15 ` Richard Guenther
2011-06-02 8:46 ` Ira Rosen
2011-06-02 9:59 ` Richard Guenther
2011-06-02 11:08 ` Ira Rosen
2011-06-02 15:35 ` Richard Guenther
2011-06-06 13:05 ` Richard Sandiford
2011-06-06 14:28 ` Richard Guenther
2011-06-07 21:08 ` H.J. Lu [this message]
2011-06-21 0:40 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikC14vNA7X2s-M2AnRDnFkqQk+5wA@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ira.rosen@linaro.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).