From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7220 invoked by alias); 10 Apr 2011 18:47:34 -0000 Received: (qmail 7210 invoked by uid 22791); 10 Apr 2011 18:47:33 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f47.google.com (HELO mail-fx0-f47.google.com) (209.85.161.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 10 Apr 2011 18:47:27 +0000 Received: by fxm19 with SMTP id 19so3832405fxm.20 for ; Sun, 10 Apr 2011 11:47:26 -0700 (PDT) Received: by 10.223.6.11 with SMTP id 11mr28192fax.92.1302461246149; Sun, 10 Apr 2011 11:47:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.81.75 with HTTP; Sun, 10 Apr 2011 11:47:05 -0700 (PDT) In-Reply-To: <20110408195551.4804bbfe.basile@starynkevitch.net> References: <20110404215335.032d7b9c.basile@starynkevitch.net> <20110408074445.4ee15190.basile@starynkevitch.net> <20110408195551.4804bbfe.basile@starynkevitch.net> From: Laurynas Biveinis Date: Sun, 10 Apr 2011 18:47:00 -0000 Message-ID: Subject: Re: PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode. To: Basile Starynkevitch Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00712.txt.bz2 2011/4/8 Basile Starynkevitch : > Actually, the above committed patch is better than nothing, but not > perfect. It happens to generate ggc_alloc macros for things which are > not defined in the plugin (however, this is not a big deal in practice, > since it generates some macros in common with those inside > gtype-desc.h). I think it is rather hard to solve it properly, i.e. only output what is actually used. But, as you said, it is benign, so I think we'll have to keep ignoring it for now. -- Laurynas