From: Kai Tietz <ktietz70@googlemail.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Paolo Bonzini <bonzini@gnu.org>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch gimplifier]: Boolify more strict conditional expressions and transform simple form to binary
Date: Tue, 10 May 2011 17:28:00 -0000 [thread overview]
Message-ID: <BANLkTikD0aNP8E2r0hDji6V7aU+xL=GGCQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimXbNg7no3=bP37U+4chyJhW7E1OA@mail.gmail.com>
2011/5/10 Richard Guenther <richard.guenther@gmail.com>:
> On Tue, May 10, 2011 at 5:30 PM, Paolo Bonzini <bonzini@gnu.org> wrote:
>> On 05/10/2011 05:23 PM, Richard Guenther wrote:
>>>
>>> I suppose you have testcases for all the cases you looked at, please
>>> add some that cover these corner cases.
>>
>> Also, there is quite some tree-vrp.c dead code with these changes. Removing
>> the TRUTH_*_CODE handling in VRP will help finding more places where the
>> middle-end is building boolean operations. There should be testcases
>> covering these parts of VRP.
>
> Btw, you can split the patch into two pieces - first, make TRUTH_*
> expressions correctly typed (take boolean typed operands and procude
> a boolean typed result) and verify that in verify_gimple_assign_binary.
> A second patch than can do the s/TRUTH_/BIT_/ substitution during
> gimplification. That way the first (and more difficult) part doesn't get
> too big with unrelated changes.
>
> Richard.
>
>> Paolo
>>
>
Well, I think I found one big issue here about booified expression of
condition. The gimple_boolify needs to handle COND_EXPR in more
detail. As if a conditional expression has to be boolified, it means
its condition and its other operands need to be boolified, too. And
this is for sure one cause, why I see for ANDIF/ORIF and the truth
AND|OR|XOR none boolean types.
I will continue on that.
To split this seems to make sense, as I have to touch much more areas
for the TRUTH to BIT conversion.
Regards,
Kai
next prev parent reply other threads:[~2011-05-10 16:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 14:25 Kai Tietz
2011-05-10 15:24 ` Richard Guenther
2011-05-10 15:34 ` Kai Tietz
2011-05-10 15:38 ` Richard Guenther
2011-05-10 15:45 ` Paolo Bonzini
2011-05-10 15:52 ` Richard Guenther
2011-05-10 17:28 ` Kai Tietz [this message]
2011-05-10 20:49 ` Kai Tietz
2011-05-11 9:35 ` Richard Guenther
2011-05-11 10:06 ` Kai Tietz
2011-05-11 10:51 ` Kai Tietz
2011-05-11 10:00 ` Kai Tietz
2011-05-11 10:03 ` Richard Guenther
2011-05-11 10:12 ` Kai Tietz
2011-05-11 10:31 ` Kai Tietz
2011-05-11 12:08 ` Richard Guenther
2011-05-11 10:46 ` Eric Botcazou
2011-05-11 11:12 ` Kai Tietz
2011-05-11 12:16 ` Richard Guenther
2011-05-11 19:39 ` Kai Tietz
2011-05-12 10:32 ` Richard Guenther
2011-05-12 14:57 ` Kai Tietz
2011-05-12 15:41 ` Richard Guenther
2011-05-12 21:33 ` Kai Tietz
2011-05-12 22:48 ` H.J. Lu
2011-05-13 10:07 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikD0aNP8E2r0hDji6V7aU+xL=GGCQ@mail.gmail.com' \
--to=ktietz70@googlemail.com \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).