public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xinliang David Li <davidxl@google.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Dump before flag
Date: Wed, 01 Jun 2011 20:38:00 -0000	[thread overview]
Message-ID: <BANLkTikOQWYaRinLPJp4u07gWcuYL_iOYSV73p9UbzpQ5Kongg@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinUmryLsmRCUxzg+R2HTpB-H=K=rQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

Sorry about it. Here it is.

David


On Wed, Jun 1, 2011 at 1:36 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Wed, Jun 1, 2011 at 10:26 PM, Xinliang David Li <davidxl@google.com> wrote:
>> Hi, this is a simple patch that support dump_before flag. E.g,
>>
>> -fdump-tree-pre-before
>>
>> This is useful for diffing the the IR before and after a pass.
>>
>> Gcc dumping needs more cleanups -- such as allowing IR only dump,
>> allowing IR dumping for a particular function etc. The exposure of
>> 'dumpfile' (instead of a dumping_level () function) makes those change
>> a little messy, but can be done.
>>
>> Ok for trunk?
>
> -ENOPATCH
>
>> Thanks,
>>
>> David
>>
>

[-- Attachment #2: dump_before.p --]
[-- Type: text/x-pascal, Size: 1613 bytes --]

2011-06-01  David Li  <davidxl@google.com>

	* tree-dump.c: New dump flags.
	* tree-pass.h: New dump flags.
	* passes.c (execute_one_pass): Handle dump_before flag.

Index: tree-dump.c
===================================================================
--- tree-dump.c	(revision 174446)
+++ tree-dump.c	(working copy)
@@ -808,6 +808,7 @@ struct dump_option_value_info
    in tree.h */
 static const struct dump_option_value_info dump_options[] =
 {
+  {"before",  TDF_BEFORE},
   {"address", TDF_ADDRESS},
   {"asmname", TDF_ASMNAME},
   {"slim", TDF_SLIM},
Index: tree-pass.h
===================================================================
--- tree-pass.h	(revision 174446)
+++ tree-pass.h	(working copy)
@@ -83,6 +83,7 @@ enum tree_dump_index
 #define TDF_ALIAS	(1 << 21)	/* display alias information  */
 #define TDF_ENUMERATE_LOCALS (1 << 22)	/* Enumerate locals by uid.  */
 #define TDF_CSELIB	(1 << 23)	/* Dump cselib details.  */
+#define TDF_BEFORE	(1 << 24)	/* Dump IR before pass.  */
 
 
 /* In tree-dump.c */
Index: passes.c
===================================================================
--- passes.c	(revision 174446)
+++ passes.c	(working copy)
@@ -1563,6 +1563,13 @@ execute_one_pass (struct opt_pass *pass)
 
   initializing_dump = pass_init_dump_file (pass);
 
+  /* Override dump TODOs.  */
+  if (dump_file && (pass->todo_flags_finish & TODO_dump_func)
+      && (dump_flags & TDF_BEFORE))
+    {
+      pass->todo_flags_finish &= ~TODO_dump_func;
+      pass->todo_flags_start |= TODO_dump_func;
+    }
   /* Run pre-pass verification.  */
   execute_todo (pass->todo_flags_start);
 

  reply	other threads:[~2011-06-01 20:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 20:26 Xinliang David Li
2011-06-01 20:37 ` Richard Guenther
2011-06-01 20:38   ` Xinliang David Li [this message]
2011-06-01 21:12 ` Basile Starynkevitch
2011-06-01 21:24   ` Xinliang David Li
2011-06-06 11:12     ` Richard Guenther
2011-06-06 16:21       ` Xinliang David Li
2011-06-07  9:36         ` Richard Guenther
2011-06-07 16:23           ` Xinliang David Li
2011-06-07 16:43           ` Diego Novillo
2011-06-07 16:51             ` Xinliang David Li
2011-06-07 17:01               ` Diego Novillo
2011-06-07 17:07                 ` Xinliang David Li
2011-06-07 17:26                   ` Diego Novillo
2011-06-07 23:24           ` Xinliang David Li
2011-06-07 23:34             ` Xinliang David Li
2011-06-08  6:44               ` Xinliang David Li
2011-06-08  9:29             ` Richard Guenther
2011-06-08 16:52               ` Xinliang David Li
2011-06-08 17:14               ` Xinliang David Li
2011-06-08 23:15                 ` Xinliang David Li
2011-06-09  9:28                   ` Richard Guenther
2011-06-09 15:58                     ` Xinliang David Li
2011-06-10  9:04                       ` Richard Guenther
2011-06-10 16:54                         ` Xinliang David Li
2011-06-10 18:49                           ` Xinliang David Li
2011-06-14 14:19                             ` Richard Guenther
2011-06-14 16:02                               ` Xinliang David Li
2011-06-14 20:05                                 ` Xinliang David Li
2011-06-14 23:22                                   ` Xinliang David Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikOQWYaRinLPJp4u07gWcuYL_iOYSV73p9UbzpQ5Kongg@mail.gmail.com \
    --to=davidxl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).