From: Diego Novillo <dnovillo@google.com>
To: Jason Merrill <jason@redhat.com>
Cc: Lawrence Crowl <crowl@google.com>,
reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [patch] Split Parse Timevar (issue4378056)
Date: Thu, 21 Apr 2011 20:38:00 -0000 [thread overview]
Message-ID: <BANLkTikOoryL-bRzFUZQ=EhE4qS-44s6LA@mail.gmail.com> (raw)
In-Reply-To: <4DAF5782.90009@redhat.com>
On Wed, Apr 20, 2011 at 18:00, Jason Merrill <jason@redhat.com> wrote:
> On 04/12/2011 11:49 AM, Lawrence Crowl wrote:
>>
>> This patch is available for review at
>> http://codereview.appspot.com/4378056
>
> I tried to comment there, but it didn't seem to be working; looking at the
> side-by-side diffs didn't show any changes, and double-clicking on a line in
> the patch form didn't let me add a comment.
If you are logged in and click on the file (not the side-by-side), you
can double-click on the patch hunk you want to comment on (you'll need
to cut-n-paste some context due to
http://code.google.com/p/rietveld/issues/detail?id=291&can=4).
Now, for some reason I never could quite grasp, some of Lawrence's
patches were uploaded in such a way that both the base file and the
patched file are the same. That's why the side-by-side view is not
working.
Subsequent patches from Lawrence did not have that problem. So,
whatever it was, it got fixed (but I'm not sure what fixed it).
Diego.
next prev parent reply other threads:[~2011-04-21 19:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 18:50 Lawrence Crowl
2011-04-12 19:06 ` Diego Novillo
2011-04-13 9:19 ` Richard Guenther
2011-04-13 20:57 ` Lawrence Crowl
2011-04-20 23:33 ` Jason Merrill
2011-04-21 20:38 ` Diego Novillo [this message]
2011-04-22 0:40 ` Lawrence Crowl
2011-04-22 2:34 ` Jason Merrill
2011-04-23 0:05 ` Lawrence Crowl
2011-04-24 9:34 ` Jason Merrill
2011-04-27 19:18 ` Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikOoryL-bRzFUZQ=EhE4qS-44s6LA@mail.gmail.com' \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).