From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25593 invoked by alias); 21 Apr 2011 19:58:19 -0000 Received: (qmail 25585 invoked by uid 22791); 21 Apr 2011 19:58:19 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 19:58:03 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id p3LJw14N028617 for ; Thu, 21 Apr 2011 12:58:01 -0700 Received: from ywf9 (ywf9.prod.google.com [10.192.6.9]) by wpaz1.hot.corp.google.com with ESMTP id p3LJtdBw021970 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 21 Apr 2011 12:58:00 -0700 Received: by ywf9 with SMTP id 9so24941ywf.8 for ; Thu, 21 Apr 2011 12:57:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.152.32 with SMTP id e32mr216355ano.45.1303415879267; Thu, 21 Apr 2011 12:57:59 -0700 (PDT) Received: by 10.100.133.12 with HTTP; Thu, 21 Apr 2011 12:57:59 -0700 (PDT) In-Reply-To: <4DAF5782.90009@redhat.com> References: <20110412184923.33F942225D6@jade.mtv.corp.google.com> <4DAF5782.90009@redhat.com> Date: Thu, 21 Apr 2011 20:38:00 -0000 Message-ID: Subject: Re: [patch] Split Parse Timevar (issue4378056) From: Diego Novillo To: Jason Merrill Cc: Lawrence Crowl , reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01819.txt.bz2 On Wed, Apr 20, 2011 at 18:00, Jason Merrill wrote: > On 04/12/2011 11:49 AM, Lawrence Crowl wrote: >> >> This patch is available for review at >> http://codereview.appspot.com/4378056 > > I tried to comment there, but it didn't seem to be working; looking at the > side-by-side diffs didn't show any changes, and double-clicking on a line in > the patch form didn't let me add a comment. If you are logged in and click on the file (not the side-by-side), you can double-click on the patch hunk you want to comment on (you'll need to cut-n-paste some context due to http://code.google.com/p/rietveld/issues/detail?id=291&can=4). Now, for some reason I never could quite grasp, some of Lawrence's patches were uploaded in such a way that both the base file and the patched file are the same. That's why the side-by-side view is not working. Subsequent patches from Lawrence did not have that problem. So, whatever it was, it got fixed (but I'm not sure what fixed it). Diego.