From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-295770-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15909 invoked by alias); 1 Jul 2011 14:06:44 -0000
Received: (qmail 15899 invoked by uid 22791); 1 Jul 2011 14:06:43 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jul 2011 14:06:29 +0000
Received: by qwh5 with SMTP id 5so1878868qwh.20        for <gcc-patches@gcc.gnu.org>; Fri, 01 Jul 2011 07:06:28 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.79.196 with SMTP id q4mr2608750qck.132.1309529188808; Fri, 01 Jul 2011 07:06:28 -0700 (PDT)
Received: by 10.229.214.83 with HTTP; Fri, 1 Jul 2011 07:06:28 -0700 (PDT)
In-Reply-To: <yddliwirtdj.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
References: <20110625161357.GA5401@intel.com>	<4E07A879.70509@redhat.com>	<BANLkTik8ZOfWVUV7SV1ryQ=yJtUiCG+tqQ@mail.gmail.com>	<4E089A88.60401@redhat.com>	<BANLkTimw8O0UnnVATPKgrRCVT=82sO48Dw@mail.gmail.com>	<4E0C8361.5050403@redhat.com>	<BANLkTinOGKQCq2abZW0L7CLOQ901+Oodxg@mail.gmail.com>	<4E0C904E.8090504@redhat.com>	<BANLkTiknF6h_qJ9rAgBikdAM8O7RgSdyHA@mail.gmail.com>	<BANLkTimGtPskWYsGOi+hp59DKnDW7wD2sw@mail.gmail.com>	<BANLkTimYZoGBBUxq+uMehqGxR5E1cpEavA@mail.gmail.com>	<yddvcvnxkm0.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<BANLkTikRuXz1RP1LxU8BCEFoT+pNP5e_Jw@mail.gmail.com>	<yddr56bxkb1.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<BANLkTimRWq4S4bKQpvuYzO3Go6yMc2fcgg@mail.gmail.com>	<4E0CC85E.3090401@redhat.com>	<BANLkTimt9V4kyKE2jmixeMOW=k7ghWrw+A@mail.gmail.com>	<yddaacyxtjd.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<BANLkTi=1Y8wHj6Y_vMp5GJSp-C+yNVa5dw@mail.gmail.com>	<yddvcvmrujf.fsf@manam.CeBiTec.Uni-Bielefeld.DE>	<BANLkTinfLL-Hcpr4JU7UaeD5Tdii8r20xQ@mail.gmail.com>	<yddliwirtdj.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Date: Fri, 01 Jul 2011 14:06:00 -0000
Message-ID: <BANLkTikPrxg+1n=Qr4ku19=vweOHJA3RJw@mail.gmail.com>
Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Rainer Orth <ro@cebitec.uni-bielefeld.de>
Cc: Richard Henderson <rth@redhat.com>, Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org, 	Jakub Jelinek <jakub@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-07/txt/msg00039.txt.bz2

On Fri, Jul 1, 2011 at 7:02 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> w=
rote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>>>> What is your suggestion?
>>>
>>> How about moving the md-unwind-support.h include up to the rest of the
>>> includes? =A0The headers usually only define MD_FALLBACK_FRAME_STATE_FOR
>>> and perhaps MD_FROB_UPDATE_CONTEXT, everything else is an internal
>>> helper macro, so order shouldn't matter.
>>>
>>
>> It doesn't work on Linux/x86-64:
>>
>> In file included from
>> /export/gnu/import/git/gcc/libgcc/../gcc/unwind-dw2.c:39:0:
>> ./md-unwind-support.h: In function \u2018x86_fallback_frame_state\u2019:
>> ./md-unwind-support.h:121:30: error: dereferencing pointer to incomplete=
 type
>
> Then move it below the definition of struct _Unwind_Context with a

It won't work since I need to define a macro before struct _Unwind_Context.

> comment explaining why it has to be there. =A0I thought you aspired to
> become Linux maintainer?
>

Yes, not by breaking working codes.


--=20
H.J.