From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12100 invoked by alias); 9 Jun 2011 09:08:55 -0000 Received: (qmail 12084 invoked by uid 22791); 9 Jun 2011 09:08:53 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Jun 2011 09:08:37 +0000 Received: by wye20 with SMTP id 20so1112996wye.20 for ; Thu, 09 Jun 2011 02:08:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.197.83 with SMTP id ej19mr488940wbb.105.1307610515586; Thu, 09 Jun 2011 02:08:35 -0700 (PDT) Received: by 10.227.37.152 with HTTP; Thu, 9 Jun 2011 02:08:35 -0700 (PDT) In-Reply-To: References: <9F3CD3EC-B7DD-4DA8-BA2C-64CF6F018159@comcast.net> Date: Thu, 09 Jun 2011 09:51:00 -0000 Message-ID: Subject: Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334) From: Richard Guenther To: Rainer Orth Cc: Mike Stump , gcc-patches@gcc.gnu.org, Richard Guenther , Jan Hubicka Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00715.txt.bz2 On Thu, Jun 9, 2011 at 9:14 AM, Rainer Orth w= rote: > Mike Stump writes: > >> On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: >>> =A0* lto.c (promote_var): Only set VISIBILITY_HIDDEN if >>> =A0 =A0 =A0HAVE_GAS_HIDDEN. >> >> This looks wrong, there are more things that have visibility than those = things that use GAS and have .hidden. =A0Darwin I think is one of them. =A0= ? =A0cygming.h seems to be another. > > Now that Darwin has been switched to define HAVE_GAS_HIDDEN, is the > lto.c part ok? Honza? I think if we are not marking the symbols hidden we "break" LTO in the way that we suddenly export local static symbols. So no, I don't think we want to do that - but then we need another way to make it possible to access previously local statics from a different LTO partition. Richard. > I've re-bootstrapped both patches together on i386-apple-darwin9.8.0, > powerpc-apple-darwin9.8.0, i386-pc-solaris2.8 and i386-pc-solaris2.11 > without regressions; as expected the failure on Solaris 8/x86 is gone. > > Thanks. > =A0 =A0 =A0 =A0Rainer > > -- > -------------------------------------------------------------------------= ---- > Rainer Orth, Center for Biotechnology, Bielefeld University >