From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27323 invoked by alias); 1 Jun 2011 19:29:34 -0000 Received: (qmail 27133 invoked by uid 22791); 1 Jun 2011 19:29:32 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 01 Jun 2011 19:29:17 +0000 Received: by wwf26 with SMTP id 26so157803wwf.8 for ; Wed, 01 Jun 2011 12:29:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.209.146 with SMTP id gg18mr5086824wbb.71.1306956555726; Wed, 01 Jun 2011 12:29:15 -0700 (PDT) Received: by 10.227.37.152 with HTTP; Wed, 1 Jun 2011 12:29:15 -0700 (PDT) In-Reply-To: References: Date: Wed, 01 Jun 2011 19:29:00 -0000 Message-ID: Subject: Re: -fdump-passes -fenable-xxx=func_name_list From: Richard Guenther To: Xinliang David Li Cc: GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00088.txt.bz2 On Wed, Jun 1, 2011 at 6:16 PM, Xinliang David Li wrot= e: > On Wed, Jun 1, 2011 at 1:51 AM, Richard Guenther > wrote: >> On Wed, Jun 1, 2011 at 1:34 AM, Xinliang David Li w= rote: >>> The following patch implements the a new option that dumps gcc PASS >>> configuration. The sample output is attached. =A0There is one >>> limitation: some placeholder passes that are named with '*xxx' are >>> note registered thus they are not listed. They are not important as >>> they can not be turned on/off anyway. >>> >>> The patch also enhanced -fenable-xxx and -fdisable-xx to allow a list >>> of function assembler names to be specified. >>> >>> Ok for trunk? >> >> Please split the patch. >> >> I'm not too happy how you dump the pass configuration. =A0Why not simply, >> at a _single_ place, walk the pass tree? =A0Instead of doing pieces of it >> at pass execution time when it's not already dumped - that really looks >> gross. > > Yes, that was the original plan -- but it has problems > 1) the dumper needs to know the root pass lists -- which can change > frequently -- it can be a long term maintanance burden; > 2) the centralized dumper needs to be done after option processing > 3) not sure if gate functions have any side effects or have dependencies = on cfun > > The proposed solutions IMHO is not that intrusive -- just three hooks > to do the dumping and tracking indentation. Well, if you have a CU that is empty or optimized to nothing at some point you will not get a complete pass list. I suppose optimize attributes might also confuse output. Your solution might not be that intrusive but it is still ugly. I don't see 1) as an issue, for 2) you can just call= the dumping from toplev_main before calling do_compile (), 3) gate functions shouldn't have side-effects, but as they could gate on optimize_for_speed () your option summary output will be bogus anyway. So - what is the output intended for if it isn't reliable? Richard. >> >> The documentation should also link this option to the -fenable/disable >> options as obviously the pass names in that dump are those to be >> used for those flags (and not readily available anywhere else). > > Ok. > >> >> I also think that it would be way more useful to note in the individual >> dump files the functions (at the place they would usually appear) that >> have the pass explicitly enabled/disabled. > > Ok -- for ipa passes or tree/rtl passes where all functions are > explicitly disabled. > > Thanks, > > David > >> >> Richard. >> >>> Thanks, >>> >>> David >>> >> >