From: Diego Novillo <dnovillo@google.com>
To: gchare@google.com, crowl@google.com, dnovillo@google.com,
gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com
Subject: Re: [pph] Stream scope_chain->bindings instead of global namespace (issue4661045)
Date: Thu, 23 Jun 2011 14:40:00 -0000 [thread overview]
Message-ID: <BANLkTikXpdbKoFR4tGrkrxgd+8B7OzV63Q@mail.gmail.com> (raw)
In-Reply-To: <20cf305b126ecdf41504a65470e3@google.com>
On Wed, Jun 22, 2011 at 18:25, <gchare@google.com> wrote:
> I fixed the comment: removing it and elaborating on the FIXME above it
> mentioning that
> we need to look if the namespace already exists.
Ah, OK. Thanks.
> I removed the include, I originally included it because that's where
> global_namespace is defined, but it compiles without it (which I guess
> is fine if we don't need to stick to "include what you use").
Yeah, we don't have that rule in GCC.
Diego.
next prev parent reply other threads:[~2011-06-23 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 22:46 gchare
2011-06-23 14:40 ` Diego Novillo [this message]
2011-06-23 18:01 ` Diego Novillo
2011-06-23 18:23 ` Diego Novillo
2011-06-23 18:58 ` Gabriel Charette
-- strict thread matches above, loose matches on Subject: below --
2011-06-22 22:39 Gabriel Charette
2011-06-22 21:04 dnovillo
2011-06-22 20:01 Gabriel Charette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikXpdbKoFR4tGrkrxgd+8B7OzV63Q@mail.gmail.com \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gchare@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).