From: Andrew Pinski <pinskia@gmail.com>
To: Jing Yu <jingyu@google.com>
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
Doug Kwan <dougkwan@google.com>, Guozhi Wei <carrot@google.com>,
reply@codereview.appspotmail.com,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [google] Disable getpagesize() for Android toolchain (issue4515131)
Date: Fri, 27 May 2011 04:02:00 -0000 [thread overview]
Message-ID: <BANLkTikYHLvADPANf8kY8auzACsYVnC_4g@mail.gmail.com> (raw)
In-Reply-To: <BANLkTikfvHr1tyUMvDaPh6B3z655VhaSJg@mail.gmail.com>
On Thu, May 26, 2011 at 4:47 PM, Jing Yu <jingyu@google.com> wrote:
> I have tested the following patch to skip building target libiberty
> for arm*-*-linux-androideabi. It works as intended when building
> Android arm-linux-androideabi toolchain.
>
> Doug, do we want to skip building libiberty for non arm android
> toolchain, say *-linux-android*?
>
> Joseph, do you think if similar patch is possible for trunk? I will
> send a separate email for review if this approach is the right way to
> go.
What Joseph recommended was ripping out all support for building
libiberty for the target side as it is not needed. Your patch just
skips it for those targets.
-- Pinski
next prev parent reply other threads:[~2011-05-26 23:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 11:45 Guozhi Wei
2011-05-24 12:37 ` Joseph S. Myers
2011-05-24 19:23 ` Doug Kwan (關振德)
2011-05-26 4:23 ` Jing Yu
2011-05-26 6:20 ` Doug Kwan (關振德)
2011-05-26 8:58 ` Jing Yu
2011-05-26 12:42 ` Joseph S. Myers
2011-05-27 4:01 ` Jing Yu
2011-05-27 4:02 ` Andrew Pinski [this message]
2011-05-26 9:56 ` Carrot Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikYHLvADPANf8kY8auzACsYVnC_4g@mail.gmail.com \
--to=pinskia@gmail.com \
--cc=carrot@google.com \
--cc=dougkwan@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jingyu@google.com \
--cc=joseph@codesourcery.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).