From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1040 invoked by alias); 26 May 2011 23:49:40 -0000 Received: (qmail 1027 invoked by uid 22791); 26 May 2011 23:49:40 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-iw0-f175.google.com (HELO mail-iw0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 23:49:24 +0000 Received: by iwn10 with SMTP id 10so1116600iwn.20 for ; Thu, 26 May 2011 16:49:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.159.134 with SMTP id l6mr2047251icx.16.1306453764106; Thu, 26 May 2011 16:49:24 -0700 (PDT) Received: by 10.42.224.138 with HTTP; Thu, 26 May 2011 16:49:24 -0700 (PDT) In-Reply-To: References: <20110524093904.2498F2072D@guozhiwei.sha.corp.google.com> Date: Fri, 27 May 2011 04:02:00 -0000 Message-ID: Subject: Re: [google] Disable getpagesize() for Android toolchain (issue4515131) From: Andrew Pinski To: Jing Yu Cc: "Joseph S. Myers" , Doug Kwan , Guozhi Wei , reply@codereview.appspotmail.com, gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg02118.txt.bz2 On Thu, May 26, 2011 at 4:47 PM, Jing Yu wrote: > I have tested the following patch to skip building target libiberty > for arm*-*-linux-androideabi. It works as intended when building > Android arm-linux-androideabi toolchain. > > Doug, do we want to skip building libiberty for non arm android > toolchain, say *-linux-android*? > > Joseph, do you think if similar patch is possible for trunk? I will > send a separate email for review if this approach is the right way to > go. What Joseph recommended was ripping out all support for building libiberty for the target side as it is not needed. Your patch just skips it for those targets. -- Pinski