From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21264 invoked by alias); 17 Jun 2011 23:24:44 -0000 Received: (qmail 21255 invoked by uid 22791); 17 Jun 2011 23:24:41 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-bw0-f47.google.com (HELO mail-bw0-f47.google.com) (209.85.214.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Jun 2011 23:24:26 +0000 Received: by bwz5 with SMTP id 5so279120bwz.20 for ; Fri, 17 Jun 2011 16:24:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.140.18 with SMTP id g18mr2034636bku.59.1308353064792; Fri, 17 Jun 2011 16:24:24 -0700 (PDT) Received: by 10.204.40.77 with HTTP; Fri, 17 Jun 2011 16:24:24 -0700 (PDT) In-Reply-To: References: Date: Sat, 18 Jun 2011 00:18:00 -0000 Message-ID: Subject: Re: PING: PATCH: PR other/49325: Incorrect target HAVE_INITFINI_ARRAY check From: "H.J. Lu" To: Paolo Bonzini Cc: DJ Delorie , Alexandre Oliva , gcc-patches@gcc.gnu.org, Ralf.Wildenhues@gmx.de Content-Type: multipart/mixed; boundary=0015174c3b0eaaf35f04a5f0af9c X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01369.txt.bz2 --0015174c3b0eaaf35f04a5f0af9c Content-Type: text/plain; charset=ISO-8859-1 Content-length: 862 On Fri, Jun 17, 2011 at 3:41 AM, Paolo Bonzini wrote: > Why are you not changing the gcc_AC_ macro and instead introducing > duplicate code? Perhaps the right solution is to add a final argument > to the AC_RUN_IFELSE macro (don't know, I should be on holiday and > hence I do not have the source code at hand :)); in any case this is > _not_ how you add tests that work for cross compilation. > > Paolo This target test needs run-time check. I don't know how to properly check it for cross compilation and I don't feel comfortable to change AC_RUN_IFELSE. Here is the updated patch to fix gcc_AC_INITFINI_ARRAY instead. Thanks. -- H.J. --- 2011-06-17 H.J. Lu PR other/49325 * acinclude.m4 (gcc_AC_INITFINI_ARRAY): Properly check if .init_array can be used with .ctors on targets. * configure: Regenerated. --0015174c3b0eaaf35f04a5f0af9c Content-Type: text/x-diff; charset=US-ASCII; name="gcc-pr49325-2.patch" Content-Disposition: attachment; filename="gcc-pr49325-2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gp1rhvlx0 Content-length: 8736 MjAxMS0wNi0xNyAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CVBSIG90aGVyLzQ5MzI1CgkqIGFjaW5jbHVkZS5tNCAoZ2NjX0FDX0lOSVRG SU5JX0FSUkFZKTogUHJvcGVybHkgY2hlY2sgaWYKCS5pbml0X2FycmF5IGNh biBiZSB1c2VkIHdpdGggLmN0b3JzIG9uIHRhcmdldHMuCgkqIGNvbmZpZ3Vy ZTogUmVnZW5lcmF0ZWQuCgpkaWZmIC0tZ2l0IGEvZ2NjL2FjaW5jbHVkZS5t NCBiL2djYy9hY2luY2x1ZGUubTQKaW5kZXggM2VlYzU1OS4uOWE0NWFmZiAx MDA2NDQKLS0tIGEvZ2NjL2FjaW5jbHVkZS5tNAorKysgYi9nY2MvYWNpbmNs dWRlLm00CkBAIC0zNzUsMTMgKzM3NSwxMTQgQEAgQUNfREVGVU4oW2djY19B Q19JTklURklOSV9BUlJBWV0sCiAJW10sIFsKIEFDX0NBQ0hFX0NIRUNLKGZv ciAucHJlaW5pdF9hcnJheS8uaW5pdF9hcnJheS8uZmluaV9hcnJheSBzdXBw b3J0LAogCQkgZ2NjX2N2X2luaXRmaW5pX2FycmF5LCBbZG5sCi0gIEFDX1JV Tl9JRkVMU0UoW0FDX0xBTkdfU09VUkNFKFsKKyAgaWYgdGVzdCAieCR7YnVp bGR9IiA9ICJ4JHt0YXJnZXR9IiA7IHRoZW4KKyAgICBBQ19SVU5fSUZFTFNF KFtBQ19MQU5HX1NPVVJDRShbCisjaWZkZWYgX19pYTY0X18KKy8qIFdlIHR1 cm4gb24gLnByZWluaXRfYXJyYXkvLmluaXRfYXJyYXkvLmZpbmlfYXJyYXkg c3VwcG9ydCBmb3IgaWE2NAorICAgaWYgaXQgY2FuIGJlIHVzZWQuICAqLwog c3RhdGljIGludCB4ID0gLTE7CiBpbnQgbWFpbiAodm9pZCkgeyByZXR1cm4g eDsgfQogaW50IGZvbyAodm9pZCkgeyB4ID0gMDsgfQotaW50ICgqZnApICh2 b2lkKSBfX2F0dHJpYnV0ZV9fICgoc2VjdGlvbiAoIi5pbml0X2FycmF5Iikp KSA9IGZvbztdKV0sCitpbnQgKCpmcCkgKHZvaWQpIF9fYXR0cmlidXRlX18g KChzZWN0aW9uICgiLmluaXRfYXJyYXkiKSkpID0gZm9vOworI2Vsc2UKK2V4 dGVybiB2b2lkIGFib3J0ICgpOworc3RhdGljIGludCBjb3VudDsKKworc3Rh dGljIHZvaWQKK2luaXQxMDA1ICgpCit7CisgIGlmIChjb3VudCAhPSAwKQor ICAgIGFib3J0ICgpOworICBjb3VudCA9IDEwMDU7Cit9Cit2b2lkICgqY29u c3QgaW5pdF9hcnJheTEwMDVbXSkgKCkKKyAgX19hdHRyaWJ1dGVfXyAoKHNl Y3Rpb24gKCIuaW5pdF9hcnJheS4wMTAwNSIpLCBhbGlnbmVkIChzaXplb2Yg KHZvaWQgKikpKSkKKyAgPSB7IGluaXQxMDA1IH07CitzdGF0aWMgdm9pZAor ZmluaTEwMDUgKCkKK3sKKyAgaWYgKGNvdW50ICE9IDEwMDUpCisgICAgYWJv cnQgKCk7Cit9Cit2b2lkICgqY29uc3QgZmluaV9hcnJheTEwMDVbXSkgKCkK KyAgX19hdHRyaWJ1dGVfXyAoKHNlY3Rpb24gKCIuZmluaV9hcnJheS4wMTAw NSIpLCBhbGlnbmVkIChzaXplb2YgKHZvaWQgKikpKSkKKyAgPSB7IGZpbmkx MDA1IH07CisKK3N0YXRpYyB2b2lkCitjdG9yMTAwNyAoKQoreworICBpZiAo Y291bnQgIT0gMTAwNSkKKyAgICBhYm9ydCAoKTsKKyAgY291bnQgPSAxMDA3 OworfQordm9pZCAoKmNvbnN0IGN0b3JzMTAwN1tdKSAoKQorICBfX2F0dHJp YnV0ZV9fICgoc2VjdGlvbiAoIi5jdG9ycy42NDUyOCIpLCBhbGlnbmVkIChz aXplb2YgKHZvaWQgKikpKSkKKyAgPSB7IGN0b3IxMDA3IH07CitzdGF0aWMg dm9pZAorZHRvcjEwMDcgKCkKK3sKKyAgaWYgKGNvdW50ICE9IDEwMDcpCisg ICAgYWJvcnQgKCk7CisgIGNvdW50ID0gMTAwNTsKK30KK3ZvaWQgKCpjb25z dCBkdG9yczEwMDdbXSkgKCkKKyAgX19hdHRyaWJ1dGVfXyAoKHNlY3Rpb24g KCIuZHRvcnMuNjQ1MjgiKSwgYWxpZ25lZCAoc2l6ZW9mICh2b2lkICopKSkp CisgID0geyBkdG9yMTAwNyB9OworCitzdGF0aWMgdm9pZAoraW5pdDY1NTMw ICgpCit7CisgIGlmIChjb3VudCAhPSAxMDA3KQorICAgIGFib3J0ICgpOwor ICBjb3VudCA9IDY1NTMwOworfQordm9pZCAoKmNvbnN0IGluaXRfYXJyYXk2 NTUzMFtdKSAoKQorICBfX2F0dHJpYnV0ZV9fICgoc2VjdGlvbiAoIi5pbml0 X2FycmF5LjY1NTMwIiksIGFsaWduZWQgKHNpemVvZiAodm9pZCAqKSkpKQor ICA9IHsgaW5pdDY1NTMwIH07CitzdGF0aWMgdm9pZAorZmluaTY1NTMwICgp Cit7CisgIGlmIChjb3VudCAhPSA2NTUzMCkKKyAgICBhYm9ydCAoKTsKKyAg Y291bnQgPSAxMDA3OworfQordm9pZCAoKmNvbnN0IGZpbmlfYXJyYXk2NTUz MFtdKSAoKQorICBfX2F0dHJpYnV0ZV9fICgoc2VjdGlvbiAoIi5maW5pX2Fy cmF5LjY1NTMwIiksIGFsaWduZWQgKHNpemVvZiAodm9pZCAqKSkpKQorICA9 IHsgZmluaTY1NTMwIH07CisKK3N0YXRpYyB2b2lkCitjdG9yNjU1MzUgKCkK K3sKKyAgaWYgKGNvdW50ICE9IDY1NTMwKQorICAgIGFib3J0ICgpOworICBj b3VudCA9IDY1NTM1OworfQordm9pZCAoKmNvbnN0IGN0b3JzNjU1MzVbXSkg KCkKKyAgX19hdHRyaWJ1dGVfXyAoKHNlY3Rpb24gKCIuY3RvcnMiKSwgYWxp Z25lZCAoc2l6ZW9mICh2b2lkICopKSkpCisgID0geyBjdG9yNjU1MzUgfTsK K3N0YXRpYyB2b2lkCitkdG9yNjU1MzUgKCkKK3sKKyAgaWYgKGNvdW50ICE9 IDY1NTM1KQorICAgIGFib3J0ICgpOworICBjb3VudCA9IDY1NTMwOworfQor dm9pZCAoKmNvbnN0IGR0b3JzNjU1MzVbXSkgKCkKKyAgX19hdHRyaWJ1dGVf XyAoKHNlY3Rpb24gKCIuZHRvcnMiKSwgYWxpZ25lZCAoc2l6ZW9mICh2b2lk ICopKSkpCisgID0geyBkdG9yNjU1MzUgfTsKKworaW50CittYWluICgpCit7 CisgIHJldHVybiAwOworfQorI2VuZGlmCitdKV0sCiAJICAgICBbZ2NjX2N2 X2luaXRmaW5pX2FycmF5PXllc10sIFtnY2NfY3ZfaW5pdGZpbmlfYXJyYXk9 bm9dLAotCSAgICAgW2djY19jdl9pbml0ZmluaV9hcnJheT1ub10pXSkKKwkg ICAgIFtnY2NfY3ZfaW5pdGZpbmlfYXJyYXk9bm9dKQorICAgZWxzZQorICAg ICBnY2NfY3ZfaW5pdGZpbmlfYXJyYXk9bm8KKyAgIGZpXSkKICAgZW5hYmxl X2luaXRmaW5pX2FycmF5PSRnY2NfY3ZfaW5pdGZpbmlfYXJyYXkKIF0pCiBp ZiB0ZXN0ICRlbmFibGVfaW5pdGZpbmlfYXJyYXkgPSB5ZXM7IHRoZW4KZGlm ZiAtLWdpdCBhL2djYy9jb25maWd1cmUgYi9nY2MvY29uZmlndXJlCmluZGV4 IDZmY2I1YWIuLjc0YmZkOWIgMTAwNzU1Ci0tLSBhL2djYy9jb25maWd1cmUK KysrIGIvZ2NjL2NvbmZpZ3VyZQpAQCAtMTA0NTksMTYgKzEwNDU5LDExNCBA QCAkYXNfZWNob19uICJjaGVja2luZyBmb3IgLnByZWluaXRfYXJyYXkvLmlu aXRfYXJyYXkvLmZpbmlfYXJyYXkgc3VwcG9ydC4uLiAiID4mNgogaWYgdGVz dCAiJHtnY2NfY3ZfaW5pdGZpbmlfYXJyYXkrc2V0fSIgPSBzZXQ7IHRoZW4g OgogICAkYXNfZWNob19uICIoY2FjaGVkKSAiID4mNgogZWxzZQorICAgIGlm IHRlc3QgIngke2J1aWxkfSIgPSAieCR7dGFyZ2V0fSIgOyB0aGVuCiAgICAg aWYgdGVzdCAiJGNyb3NzX2NvbXBpbGluZyIgPSB5ZXM7IHRoZW4gOgogICBn Y2NfY3ZfaW5pdGZpbmlfYXJyYXk9bm8KIGVsc2UKICAgY2F0IGNvbmZkZWZz LmggLSA8PF9BQ0VPRiA+Y29uZnRlc3QuJGFjX2V4dAogLyogZW5kIGNvbmZk ZWZzLmguICAqLwogCisjaWZkZWYgX19pYTY0X18KKy8qIFdlIHR1cm4gb24g LnByZWluaXRfYXJyYXkvLmluaXRfYXJyYXkvLmZpbmlfYXJyYXkgc3VwcG9y dCBmb3IgaWE2NAorICAgaWYgaXQgY2FuIGJlIHVzZWQuICAqLwogc3RhdGlj IGludCB4ID0gLTE7CiBpbnQgbWFpbiAodm9pZCkgeyByZXR1cm4geDsgfQog aW50IGZvbyAodm9pZCkgeyB4ID0gMDsgfQogaW50ICgqZnApICh2b2lkKSBf X2F0dHJpYnV0ZV9fICgoc2VjdGlvbiAoIi5pbml0X2FycmF5IikpKSA9IGZv bzsKKyNlbHNlCitleHRlcm4gdm9pZCBhYm9ydCAoKTsKK3N0YXRpYyBpbnQg Y291bnQ7CisKK3N0YXRpYyB2b2lkCitpbml0MTAwNSAoKQoreworICBpZiAo Y291bnQgIT0gMCkKKyAgICBhYm9ydCAoKTsKKyAgY291bnQgPSAxMDA1Owor fQordm9pZCAoKmNvbnN0IGluaXRfYXJyYXkxMDA1KSAoKQorICBfX2F0dHJp YnV0ZV9fICgoc2VjdGlvbiAoIi5pbml0X2FycmF5LjAxMDA1IiksIGFsaWdu ZWQgKHNpemVvZiAodm9pZCAqKSkpKQorICA9IHsgaW5pdDEwMDUgfTsKK3N0 YXRpYyB2b2lkCitmaW5pMTAwNSAoKQoreworICBpZiAoY291bnQgIT0gMTAw NSkKKyAgICBhYm9ydCAoKTsKK30KK3ZvaWQgKCpjb25zdCBmaW5pX2FycmF5 MTAwNSkgKCkKKyAgX19hdHRyaWJ1dGVfXyAoKHNlY3Rpb24gKCIuZmluaV9h cnJheS4wMTAwNSIpLCBhbGlnbmVkIChzaXplb2YgKHZvaWQgKikpKSkKKyAg PSB7IGZpbmkxMDA1IH07CisKK3N0YXRpYyB2b2lkCitjdG9yMTAwNyAoKQor eworICBpZiAoY291bnQgIT0gMTAwNSkKKyAgICBhYm9ydCAoKTsKKyAgY291 bnQgPSAxMDA3OworfQordm9pZCAoKmNvbnN0IGN0b3JzMTAwNykgKCkKKyAg X19hdHRyaWJ1dGVfXyAoKHNlY3Rpb24gKCIuY3RvcnMuNjQ1MjgiKSwgYWxp Z25lZCAoc2l6ZW9mICh2b2lkICopKSkpCisgID0geyBjdG9yMTAwNyB9Owor c3RhdGljIHZvaWQKK2R0b3IxMDA3ICgpCit7CisgIGlmIChjb3VudCAhPSAx MDA3KQorICAgIGFib3J0ICgpOworICBjb3VudCA9IDEwMDU7Cit9Cit2b2lk ICgqY29uc3QgZHRvcnMxMDA3KSAoKQorICBfX2F0dHJpYnV0ZV9fICgoc2Vj dGlvbiAoIi5kdG9ycy42NDUyOCIpLCBhbGlnbmVkIChzaXplb2YgKHZvaWQg KikpKSkKKyAgPSB7IGR0b3IxMDA3IH07CisKK3N0YXRpYyB2b2lkCitpbml0 NjU1MzAgKCkKK3sKKyAgaWYgKGNvdW50ICE9IDEwMDcpCisgICAgYWJvcnQg KCk7CisgIGNvdW50ID0gNjU1MzA7Cit9Cit2b2lkICgqY29uc3QgaW5pdF9h cnJheTY1NTMwKSAoKQorICBfX2F0dHJpYnV0ZV9fICgoc2VjdGlvbiAoIi5p bml0X2FycmF5LjY1NTMwIiksIGFsaWduZWQgKHNpemVvZiAodm9pZCAqKSkp KQorICA9IHsgaW5pdDY1NTMwIH07CitzdGF0aWMgdm9pZAorZmluaTY1NTMw ICgpCit7CisgIGlmIChjb3VudCAhPSA2NTUzMCkKKyAgICBhYm9ydCAoKTsK KyAgY291bnQgPSAxMDA3OworfQordm9pZCAoKmNvbnN0IGZpbmlfYXJyYXk2 NTUzMCkgKCkKKyAgX19hdHRyaWJ1dGVfXyAoKHNlY3Rpb24gKCIuZmluaV9h cnJheS42NTUzMCIpLCBhbGlnbmVkIChzaXplb2YgKHZvaWQgKikpKSkKKyAg PSB7IGZpbmk2NTUzMCB9OworCitzdGF0aWMgdm9pZAorY3RvcjY1NTM1ICgp Cit7CisgIGlmIChjb3VudCAhPSA2NTUzMCkKKyAgICBhYm9ydCAoKTsKKyAg Y291bnQgPSA2NTUzNTsKK30KK3ZvaWQgKCpjb25zdCBjdG9yczY1NTM1KSAo KQorICBfX2F0dHJpYnV0ZV9fICgoc2VjdGlvbiAoIi5jdG9ycyIpLCBhbGln bmVkIChzaXplb2YgKHZvaWQgKikpKSkKKyAgPSB7IGN0b3I2NTUzNSB9Owor c3RhdGljIHZvaWQKK2R0b3I2NTUzNSAoKQoreworICBpZiAoY291bnQgIT0g NjU1MzUpCisgICAgYWJvcnQgKCk7CisgIGNvdW50ID0gNjU1MzA7Cit9Cit2 b2lkICgqY29uc3QgZHRvcnM2NTUzNSkgKCkKKyAgX19hdHRyaWJ1dGVfXyAo KHNlY3Rpb24gKCIuZHRvcnMiKSwgYWxpZ25lZCAoc2l6ZW9mICh2b2lkICop KSkpCisgID0geyBkdG9yNjU1MzUgfTsKKworaW50CittYWluICgpCit7Cisg IHJldHVybiAwOworfQorI2VuZGlmCisKIF9BQ0VPRgogaWYgYWNfZm5fY190 cnlfcnVuICIkTElORU5PIjsgdGhlbiA6CiAgIGdjY19jdl9pbml0ZmluaV9h cnJheT15ZXMKQEAgLTEwNDc5LDYgKzEwNTc3LDkgQEAgcm0gLWYgY29yZSAq LmNvcmUgY29yZS5jb25mdGVzdC4qIGdtb24ub3V0IGJiLm91dCBjb25mdGVz dCRhY19leGVleHQgXAogICBjb25mdGVzdC4kYWNfb2JqZXh0IGNvbmZ0ZXN0 LmJlYW0gY29uZnRlc3QuJGFjX2V4dAogZmkKIAorICAgZWxzZQorICAgICBn Y2NfY3ZfaW5pdGZpbmlfYXJyYXk9bm8KKyAgIGZpCiBmaQogeyAkYXNfZWNo byAiJGFzX21lOiR7YXNfbGluZW5vLSRMSU5FTk99OiByZXN1bHQ6ICRnY2Nf Y3ZfaW5pdGZpbmlfYXJyYXkiID4mNQogJGFzX2VjaG8gIiRnY2NfY3ZfaW5p dGZpbmlfYXJyYXkiID4mNjsgfQpAQCAtMTc1MjAsNyArMTc2MjEsNyBAQCBl bHNlCiAgIGx0X2RsdW5rbm93bj0wOyBsdF9kbG5vX3VzY29yZT0xOyBsdF9k bG5lZWRfdXNjb3JlPTIKICAgbHRfc3RhdHVzPSRsdF9kbHVua25vd24KICAg Y2F0ID4gY29uZnRlc3QuJGFjX2V4dCA8PF9MVF9FT0YKLSNsaW5lIDE3NTIz ICJjb25maWd1cmUiCisjbGluZSAxNzYyNCAiY29uZmlndXJlIgogI2luY2x1 ZGUgImNvbmZkZWZzLmgiCiAKICNpZiBIQVZFX0RMRkNOX0gKQEAgLTE3NjI2 LDcgKzE3NzI3LDcgQEAgZWxzZQogICBsdF9kbHVua25vd249MDsgbHRfZGxu b191c2NvcmU9MTsgbHRfZGxuZWVkX3VzY29yZT0yCiAgIGx0X3N0YXR1cz0k bHRfZGx1bmtub3duCiAgIGNhdCA+IGNvbmZ0ZXN0LiRhY19leHQgPDxfTFRf RU9GCi0jbGluZSAxNzYyOSAiY29uZmlndXJlIgorI2xpbmUgMTc3MzAgImNv bmZpZ3VyZSIKICNpbmNsdWRlICJjb25mZGVmcy5oIgogCiAjaWYgSEFWRV9E TEZDTl9ICg== --0015174c3b0eaaf35f04a5f0af9c--