From: Diego Novillo <dnovillo@google.com>
To: Le-Chun Wu <lcwu@google.com>, Diego Novillo <dnovillo@google.com>,
Jeffrey Yasskin <jyasskin@google.com>,
Ollie Wild <aaw@google.com>,
delesley@google.com, gcc-patches@gcc.gnu.org,
reply@codereview.appspotmail.com
Subject: Re: [google] Enhance Annotalysis to support cloned functions/methods (issue4591066)
Date: Mon, 13 Jun 2011 20:39:00 -0000 [thread overview]
Message-ID: <BANLkTik_00xfy2BZ9PPFJwUDHxHmb7gyVQ@mail.gmail.com> (raw)
In-Reply-To: <20cf303b397b27332004a59d261b@google.com>
On Mon, Jun 13, 2011 at 12:44, <lcwu@google.com> wrote:
>> could
>> 2149 be optimized away. */
>> 2150 if (TREE_CODE (TREE_TYPE (DECL_ORIGIN (fdecl))) == METHOD_TYPE
>> 2151 && gimple_call_num_args(call) > 0)
>
>> Wouldn't it be easier to make fdecl == DECL_ORIGIN (fdecl) earlier in
>
> the
>>
>> function?
>
>> It's OK either way, though.
>
> Yes, my original fix was to make fdecl = DECL_ORIGINAL (fdecl). But I
> later changed it to this way because I wanted to tolerate the case where
> the base object (i.e. "this" pointer) is an object instead of a pointer
> only when fdecl is a clone. (i.e. I don't want to arbitrarily relax it.)
> That's why I kept fdecl intact.
Ah, makes sense. Thanks.
Diego.
next prev parent reply other threads:[~2011-06-13 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 20:12 lcwu
2011-06-13 20:39 ` Diego Novillo [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-06-11 18:53 dnovillo
2011-06-11 6:22 Le-Chun Wu
2011-06-10 18:31 Le-Chun Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik_00xfy2BZ9PPFJwUDHxHmb7gyVQ@mail.gmail.com \
--to=dnovillo@google.com \
--cc=aaw@google.com \
--cc=delesley@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jyasskin@google.com \
--cc=lcwu@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).