public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Guenther <richard.guenther@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Richard Guenther <rguenther@suse.de>,
	Jason Merrill <jason@redhat.com>,
		gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: RFA (fold): PATCH for c++/49290 (folding *(T*)(ar+10))
Date: Thu, 16 Jun 2011 07:39:00 -0000	[thread overview]
Message-ID: <BANLkTikeXbH74+8hJsxYQmU2w9PsxC6oJw@mail.gmail.com> (raw)
In-Reply-To: <A1950AA7-7F10-47AA-A36A-663A076ADA86@comcast.net>

On Wed, Jun 15, 2011 at 7:46 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Jun 15, 2011, at 2:04 AM, Richard Guenther wrote:
>> This VIEW_CONVERT_EXPR looks useless - in fact useless_type_conversion_p
>> will tell you that, so you can omit it.
>
> So, I tracked down who created it:
>
> tree
> convert_to_vector (tree type, tree expr)
> {
>  switch (TREE_CODE (TREE_TYPE (expr)))
>    {
>    case INTEGER_TYPE:
>    case VECTOR_TYPE:
>      if (!tree_int_cst_equal (TYPE_SIZE (type), TYPE_SIZE (TREE_TYPE (expr))))
>        {
>          error ("can%'t convert between vector values of different size");
>          return error_mark_node;
>        }
> =>    return build1 (VIEW_CONVERT_EXPR, type, expr);
>
> If people want to not create useless conversions in the first place, though, I suspect there are lots of places that create useless conversions in the compiler.

Yeah, the above looks it comes from the frontends - gimplification
should strip this conversion, if it doesn't that is a bug ;)

Richard.

  reply	other threads:[~2011-06-16  7:36 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07  5:39 Jason Merrill
2011-06-07 10:20 ` Richard Guenther
2011-06-07 10:27   ` Jakub Jelinek
2011-06-07 12:03     ` Richard Guenther
2011-06-07 12:22       ` Richard Guenther
2011-06-07 13:46         ` Michael Matz
2011-06-07 13:49           ` Richard Guenther
2011-06-07 13:55   ` Jason Merrill
2011-06-07 14:05     ` Richard Guenther
2011-06-07 14:24       ` Jason Merrill
2011-06-09 19:47         ` Jason Merrill
2011-06-10  8:53           ` Richard Guenther
2011-06-10 14:03             ` Jason Merrill
2011-06-10 14:20               ` Richard Guenther
2011-06-10 14:32                 ` Jason Merrill
2011-06-10 14:34                   ` Richard Guenther
2011-06-10 14:45                     ` Jason Merrill
2011-06-11 18:24                     ` Mike Stump
2011-06-12 11:03                       ` Richard Guenther
2011-06-13  7:29                         ` Mike Stump
2011-06-13 12:46                           ` Richard Guenther
2011-06-14 20:31                             ` Mike Stump
2011-06-15  9:54                               ` Richard Guenther
2011-06-15 18:57                                 ` Mike Stump
2011-06-16  7:39                                   ` Richard Guenther [this message]
2011-06-17 14:17                                     ` Michael Matz
2011-06-20 10:24                                       ` Richard Guenther
2011-06-12  7:58                     ` Is VIEW_CONVERT_EXPR an lvalue? (was Re: RFA (fold): PATCH for c++/49290 (folding *(T*)(ar+10))) Jason Merrill
2011-06-12 13:18                       ` Richard Guenther
2011-06-12 13:22                         ` Richard Guenther
2011-06-13  6:12                           ` Mike Stump
2011-06-12 22:42                         ` Jason Merrill
2011-06-13 12:44                           ` Richard Guenther
2011-06-13 17:59                             ` RFA (fold): PATCH for c++/49290 (folding *(T*)(ar+10)) Jason Merrill
2011-06-14  9:10                               ` Richard Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTikeXbH74+8hJsxYQmU2w9PsxC6oJw@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=mikestump@comcast.net \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).