From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31943 invoked by alias); 26 May 2011 23:48:03 -0000 Received: (qmail 31886 invoked by uid 22791); 26 May 2011 23:48:02 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 23:47:48 +0000 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id p4QNljDJ027031 for ; Thu, 26 May 2011 16:47:45 -0700 Received: from pvg13 (pvg13.prod.google.com [10.241.210.141]) by kpbe16.cbf.corp.google.com with ESMTP id p4QNlTai023840 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 26 May 2011 16:47:44 -0700 Received: by pvg13 with SMTP id 13so584568pvg.26 for ; Thu, 26 May 2011 16:47:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.213.20 with SMTP id l20mr234342wfg.203.1306453663887; Thu, 26 May 2011 16:47:43 -0700 (PDT) Received: by 10.142.212.11 with HTTP; Thu, 26 May 2011 16:47:43 -0700 (PDT) In-Reply-To: References: <20110524093904.2498F2072D@guozhiwei.sha.corp.google.com> Date: Fri, 27 May 2011 04:01:00 -0000 Message-ID: Subject: Re: [google] Disable getpagesize() for Android toolchain (issue4515131) From: Jing Yu To: "Joseph S. Myers" Cc: Doug Kwan , Guozhi Wei , reply@codereview.appspotmail.com, gcc-patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg02117.txt.bz2 I have tested the following patch to skip building target libiberty for arm*-*-linux-androideabi. It works as intended when building Android arm-linux-androideabi toolchain. Doug, do we want to skip building libiberty for non arm android toolchain, say *-linux-android*? Joseph, do you think if similar patch is possible for trunk? I will send a separate email for review if this approach is the right way to go. Thanks, Jing Index: configure.ac =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- configure.ac (revision 174299) +++ configure.ac (working copy) @@ -515,7 +515,7 @@ sh*-*-pe|mips*-*-pe|*arm-wince-pe) noconfigdirs=3D"$noconfigdirs target-libiberty" ;; - arm*-*-symbianelf*) + arm*-*-symbianelf*|arm*-*-linux-androideabi) noconfigdirs=3D"$noconfigdirs target-libiberty" ;; avr-*-*) Index: configure =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- configure (revision 174299) +++ configure (working copy) @@ -3069,7 +3069,7 @@ sh*-*-pe|mips*-*-pe|*arm-wince-pe) noconfigdirs=3D"$noconfigdirs target-libiberty" ;; - arm*-*-symbianelf*) + arm*-*-symbianelf*|arm*-*-linux-androideabi) noconfigdirs=3D"$noconfigdirs target-libiberty" ;; avr-*-*) On Thu, May 26, 2011 at 5:00 AM, Joseph S. Myers wrote: > On Wed, 25 May 2011, Jing Yu wrote: > >> I am wondering how to disable build of libiberty for target? I > > Tear out all the target-libiberty code unconditionally? =A0See > and references > therein; building target libiberty at all is a bug in my view. > >> In some environment we still need to build libstdc++ libraries, where >> libiberty has to be built for target. Can we use #ifndef __ANDROID__ >> to wrap around the getpagesize() definition? It is working for us. > > See what I said in > . =A0libstdc++-v3 > does not use target libiberty; it uses one source file from the libiberty > directory. > > -- > Joseph S. Myers > joseph@codesourcery.com >