From: Diego Novillo <dnovillo@google.com>
To: Lawrence Crowl <crowl@google.com>
Cc: reply@codereview.appspotmail.com, tromey@redhat.com,
gcc-patches@gcc.gnu.org
Subject: Re: [pph] Macro Validation Correction (issue4425041)
Date: Mon, 18 Apr 2011 19:23:00 -0000 [thread overview]
Message-ID: <BANLkTikfzudr_UevUc0hMUM2WSBwTkb=8w@mail.gmail.com> (raw)
In-Reply-To: <BANLkTik0tPf2nBrSYSTaT-A_Ue957vfFFg@mail.gmail.com>
On Mon, Apr 18, 2011 at 14:58, Lawrence Crowl <crowl@google.com> wrote:
> On 4/16/11, Diego Novillo <dnovillo@google.com> wrote:
>> On Apr 14, 2011 Lawrence Crowl <crowl@google.com> wrote:
>> > +/* Make sure the bitfield directive_index in include/cpplib.h is large
>> > + enough to index the entire table. */
>> > +
>> > +unsigned char too_many_directives_for_bitfield[
>> > + N_DIRECTIVES <= (1 << CPP_HASHNODE_INDEX_BITS)
>> > + ? 1 : -1];
>>
>> Heh, I'm not sure what to think of this trick. I think I like
>> it, though.
>
> It is used elsewhere in gcc. I took that use as permission to
> reuse the technique.
Yeah, it wasn't an objection. I just find it interesting. I'm fine
with it, of course.
Diego.
next prev parent reply other threads:[~2011-04-18 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 3:39 Lawrence Crowl
2011-04-16 17:37 ` Diego Novillo
2011-04-18 13:34 ` Tom Tromey
2011-04-18 19:04 ` Lawrence Crowl
2011-04-18 19:23 ` Diego Novillo [this message]
2011-04-23 0:50 ` Hans-Peter Nilsson
2011-04-25 18:58 ` Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTikfzudr_UevUc0hMUM2WSBwTkb=8w@mail.gmail.com' \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).