From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26873 invoked by alias); 5 May 2011 10:22:36 -0000 Received: (qmail 26847 invoked by uid 22791); 5 May 2011 10:22:34 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 May 2011 10:22:19 +0000 Received: by wwf26 with SMTP id 26so2059616wwf.8 for ; Thu, 05 May 2011 03:22:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.182.129 with SMTP id cc1mr2279457wbb.10.1304590938268; Thu, 05 May 2011 03:22:18 -0700 (PDT) Received: by 10.227.20.74 with HTTP; Thu, 5 May 2011 03:22:18 -0700 (PDT) In-Reply-To: <201105051207.51449.ebotcazou@adacore.com> References: <201105051123.34184.ebotcazou@adacore.com> <201105051207.51449.ebotcazou@adacore.com> Date: Thu, 05 May 2011 11:03:00 -0000 Message-ID: Subject: Re: [google]: initialize language field for clone function struct From: Richard Guenther To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org, Xinliang David Li , Jan Hubicka Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00396.txt.bz2 On Thu, May 5, 2011 at 12:07 PM, Eric Botcazou wrot= e: >> But where do you expand it without the SAVE_EXPR? =A0The same >> restrictions apply there. =A0So I suppose you expand it to a function >> in which case there is the context where the SAVE_EXPR can be >> expanded exactly once. > > You don't have SAVE_EXPRs so you're precisely controlling what you're doi= ng. > Once a SAVE_EXPR is generated, things are pretty much out of control for = the > front-end. > >> But maybe I'm confused and simply lack an actual testcase that >> shows the issue ;) > > Remove the call to global_bindings_p from variable_size and run gnat.dg. Hm, ok. I was more looking at removing the calls from fold-const.c where it seems to protect things like folding x <=3D +Inf to x =3D=3D x, stuff un= likely to appear in type sizes. I can imagine the Ada FE wanting to do things with type sizes and variable_size's wrapping looks like merely an optimization to me (for re-using values in nested array types for example(?)). Richard. > -- > Eric Botcazou >