From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5312 invoked by alias); 10 Jun 2011 18:49:58 -0000 Received: (qmail 5303 invoked by uid 22791); 10 Jun 2011 18:49:58 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 18:49:44 +0000 Received: by wwf26 with SMTP id 26so2788672wwf.8 for ; Fri, 10 Jun 2011 11:49:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.197.206 with SMTP id el14mr2498521wbb.90.1307731782686; Fri, 10 Jun 2011 11:49:42 -0700 (PDT) Received: by 10.227.37.152 with HTTP; Fri, 10 Jun 2011 11:49:42 -0700 (PDT) In-Reply-To: <20110610184247.GA3252@kam.mff.cuni.cz> References: <20110610184247.GA3252@kam.mff.cuni.cz> Date: Fri, 10 Jun 2011 20:10:00 -0000 Message-ID: Subject: Re: Cgraph alias reorg 13/14 (disable inlining functions called once at -O0 From: Richard Guenther To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00882.txt.bz2 On Fri, Jun 10, 2011 at 8:42 PM, Jan Hubicka wrote: > Hi, > by some mistake we enable functions called once at -O0 and it actually ha= ppens from > time to time. Why do it for -O1? It definitely makes debugging less reliable. I'd say d= o it for -O[23s] only. Richard. > Bootstrapped/regtested x86_64-linux, will commit it shortly. > > Honza > > =A0 =A0 =A0 =A0* opts.c (default_options): Enlist OPT_finline_functions_c= alled_once. > =A0 =A0 =A0 =A0* common.opt (flag_inline_functions_called_once):Do not in= itialize to 1. > Index: opts.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- opts.c =A0 =A0 =A0(revision 174916) > +++ opts.c =A0 =A0 =A0(working copy) > @@ -486,6 +486,7 @@ static const struct default_options defa > =A0 =A0 /* Inlining of functions reducing size is a good idea with -Os > =A0 =A0 =A0 =A0regardless of them being declared inline. =A0*/ > =A0 =A0 { OPT_LEVELS_3_PLUS_AND_SIZE, OPT_finline_functions, NULL, 1 }, > + =A0 =A0{ OPT_LEVELS_1_PLUS, OPT_finline_functions_called_once, NULL, 1 = }, > =A0 =A0 { OPT_LEVELS_3_PLUS, OPT_funswitch_loops, NULL, 1 }, > =A0 =A0 { OPT_LEVELS_3_PLUS, OPT_fgcse_after_reload, NULL, 1 }, > =A0 =A0 { OPT_LEVELS_3_PLUS, OPT_ftree_vectorize, NULL, 1 }, > Index: common.opt > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- common.opt =A0(revision 174916) > +++ common.opt =A0(working copy) > @@ -1233,7 +1233,7 @@ Common Report Var(flag_inline_functions) > =A0Integrate simple functions into their callers > > =A0finline-functions-called-once > -Common Report Var(flag_inline_functions_called_once) Init(1) Optimization > +Common Report Var(flag_inline_functions_called_once) Optimization > =A0Integrate functions called once into their callers > > =A0finline-limit- >