From: Steven Bosscher <stevenb.gcc@gmail.com>
To: Diego Novillo <dnovillo@google.com>
Cc: Sharad Singhai <singhai@google.com>,
reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [google] Improve locus information during if-conversion (issue4526101)
Date: Thu, 02 Jun 2011 12:47:00 -0000 [thread overview]
Message-ID: <BANLkTim0tO3doSQr8qnAp+6+Dyz14FLg3Q@mail.gmail.com> (raw)
In-Reply-To: <BANLkTik2w9Lt5n--Okpddyhairbhg_T7Sw@mail.gmail.com>
On Thu, Jun 2, 2011 at 1:46 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Wed, Jun 1, 2011 at 21:03, Sharad Singhai <singhai@google.com> wrote:
>
>> 2011-06-01 Sharad Singhai <singhai@google.com>
>>
>> Google Ref 39994
>> * ifcvt.c (noce_try_cmove_arith): Use the locus information
>> from the if-statment rather than the then path.
>
> Could you elaborate how it improves locus information? Is there a
> test case you can add to the testsuite? Or an example code fragment
> that shows how is the locus better now?
>
> OK for google/main.
Why can't this patch just go onto the trunk?
(Idem for some other google/main patches -- is there a merge plan??)
Ciao!
Steven
next prev parent reply other threads:[~2011-06-02 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 1:04 Sharad Singhai
2011-06-02 11:46 ` Diego Novillo
2011-06-02 12:47 ` Steven Bosscher [this message]
2011-06-02 12:54 ` Diego Novillo
2011-06-02 16:46 ` Sharad Singhai (शरद सिंघई)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim0tO3doSQr8qnAp+6+Dyz14FLg3Q@mail.gmail.com \
--to=stevenb.gcc@gmail.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
--cc=singhai@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).