From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 402 invoked by alias); 2 Jun 2011 12:47:05 -0000 Received: (qmail 390 invoked by uid 22791); 2 Jun 2011 12:47:04 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-yx0-f175.google.com (HELO mail-yx0-f175.google.com) (209.85.213.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Jun 2011 12:46:48 +0000 Received: by yxj19 with SMTP id 19so65648yxj.20 for ; Thu, 02 Jun 2011 05:46:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.145.37 with SMTP id x37mr495317ann.22.1307018807185; Thu, 02 Jun 2011 05:46:47 -0700 (PDT) Received: by 10.100.250.17 with HTTP; Thu, 2 Jun 2011 05:46:47 -0700 (PDT) In-Reply-To: References: <20110602010346.35A3D15C1BE@nabu.mtv.corp.google.com> Date: Thu, 02 Jun 2011 12:47:00 -0000 Message-ID: Subject: Re: [google] Improve locus information during if-conversion (issue4526101) From: Steven Bosscher To: Diego Novillo Cc: Sharad Singhai , reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00146.txt.bz2 On Thu, Jun 2, 2011 at 1:46 PM, Diego Novillo wrote: > On Wed, Jun 1, 2011 at 21:03, Sharad Singhai wrote: > >> 2011-06-01 =A0Sharad Singhai =A0 >> >> =A0 =A0 =A0 =A0Google Ref 39994 >> =A0 =A0 =A0 =A0* ifcvt.c (noce_try_cmove_arith): Use the locus informati= on >> =A0 =A0 =A0 =A0from the if-statment rather than the then path. > > Could you elaborate how it improves locus information? =A0Is there a > test case you can add to the testsuite? =A0Or an example code fragment > that shows how is the locus better now? > > OK for google/main. Why can't this patch just go onto the trunk? (Idem for some other google/main patches -- is there a merge plan??) Ciao! Steven