public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: [RFA/libiberty] Darwin has case-insensitive filesystems
Date: Tue, 14 Jun 2011 22:06:00 -0000	[thread overview]
Message-ID: <BANLkTimEjXmLHD6c=U-oRp06dkpdaO5RCg@mail.gmail.com> (raw)
In-Reply-To: <1308087182-26577-1-git-send-email-brobecker@adacore.com>

On Tue, Jun 14, 2011 at 2:33 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> Hello,
>
> HFS+, the FS on Darwin, is case insensitive. So this patch adjusts
> filename_cmp.c to ignore the casing when comparing filenames on Darwin.

This is wrong as not all FSs are case insensitive.  In fact HFS+ can
be case sensitive too.  I think you need better check than just saying
all Darwin is case insensitive.  This is just like using FAT32 on
Linux.  In fact I think HAVE_DOS_BASED_FILE_SYSTEM is incorrect also
for NTFS as it can also be case sensitive.

Thanks,
Andrew Pinski

  parent reply	other threads:[~2011-06-14 21:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 21:57 Joel Brobecker
2011-06-14 22:02 ` DJ Delorie
2011-07-01 17:58   ` Joel Brobecker
2011-06-14 22:06 ` Andrew Pinski [this message]
2011-06-14 22:13   ` DJ Delorie
2011-06-15  4:25     ` Tristan Gingold
2011-06-15  8:14     ` Joel Brobecker
2011-06-15  9:30     ` Corinna Vinschen
2011-06-15 10:44       ` Mark Kettenis
2011-06-15 10:55         ` Corinna Vinschen
2011-06-15 11:00           ` Pedro Alves
2011-06-15 11:26         ` Robert Dewar
2011-06-15 17:47           ` Eli Zaretskii
2011-06-15 10:59       ` Joseph S. Myers
2011-06-15 11:07         ` Corinna Vinschen
2011-06-15 17:35       ` Eli Zaretskii
2011-06-15 21:11         ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTimEjXmLHD6c=U-oRp06dkpdaO5RCg@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).