From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1866 invoked by alias); 14 Jun 2011 21:57:04 -0000 Received: (qmail 1850 invoked by uid 22791); 14 Jun 2011 21:57:04 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-iw0-f175.google.com (HELO mail-iw0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Jun 2011 21:56:50 +0000 Received: by iwn19 with SMTP id 19so3954446iwn.20 for ; Tue, 14 Jun 2011 14:56:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.42.133.67 with SMTP id g3mr5179569ict.51.1308088609891; Tue, 14 Jun 2011 14:56:49 -0700 (PDT) Received: by 10.42.228.199 with HTTP; Tue, 14 Jun 2011 14:56:49 -0700 (PDT) In-Reply-To: <1308087182-26577-1-git-send-email-brobecker@adacore.com> References: <1308087182-26577-1-git-send-email-brobecker@adacore.com> Date: Tue, 14 Jun 2011 22:06:00 -0000 Message-ID: Subject: Re: [RFA/libiberty] Darwin has case-insensitive filesystems From: Andrew Pinski To: Joel Brobecker Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01116.txt.bz2 On Tue, Jun 14, 2011 at 2:33 PM, Joel Brobecker wrote: > Hello, > > HFS+, the FS on Darwin, is case insensitive. So this patch adjusts > filename_cmp.c to ignore the casing when comparing filenames on Darwin. This is wrong as not all FSs are case insensitive. In fact HFS+ can be case sensitive too. I think you need better check than just saying all Darwin is case insensitive. This is just like using FAT32 on Linux. In fact I think HAVE_DOS_BASED_FILE_SYSTEM is incorrect also for NTFS as it can also be case sensitive. Thanks, Andrew Pinski