From: Andrew Pinski <pinskia@gmail.com>
To: Gabriel Dos Reis <gdr@cs.tamu.edu>
Cc: Richard Sandiford <richard.sandiford@linaro.org>,
gcc-patches@gcc.gnu.org
Subject: Re: restore bootstrap with a C++ compiler
Date: Thu, 28 Apr 2011 01:48:00 -0000 [thread overview]
Message-ID: <BANLkTimFAfbnN-dYxDLNLPdGbsTPpD6mUw@mail.gmail.com> (raw)
In-Reply-To: <87fwp3qi11.fsf@gauss.cs.tamu.edu>
On Wed, Apr 27, 2011 at 6:30 PM, Gabriel Dos Reis <gdr@cs.tamu.edu> wrote:
>
> Richard,
>
> Your recent patch broke --enable-build-with-cxx because internal-fn.h
> was using good 'ol C-style name lookup trick that behaves badly with
> C++ linkage rules. Fixed thusly. Applied as obvious.
Can you explain some more? Does it have do with the fact those
functions are static? If so I think we should move away from static
functions for compiling with C++ and move to using anonymous
namespaces.
Thanks,
Andrew Pinski
next prev parent reply other threads:[~2011-04-28 1:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 1:46 Gabriel Dos Reis
2011-04-28 1:48 ` Andrew Pinski [this message]
2011-04-28 2:10 ` Gabriel Dos Reis
2011-04-28 3:51 ` Andrew Pinski
2011-04-28 6:31 ` Gabriel Dos Reis
2011-04-28 9:37 ` Richard Sandiford
2011-04-28 14:08 ` Gabriel Dos Reis
2011-04-28 14:09 ` Richard Sandiford
2011-04-28 15:08 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimFAfbnN-dYxDLNLPdGbsTPpD6mUw@mail.gmail.com \
--to=pinskia@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@cs.tamu.edu \
--cc=richard.sandiford@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).