From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29543 invoked by alias); 13 Jun 2011 13:11:42 -0000 Received: (qmail 29299 invoked by uid 22791); 13 Jun 2011 13:11:41 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_LR,TW_RQ,TW_TQ X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Jun 2011 13:11:27 +0000 Received: by qwh5 with SMTP id 5so2438588qwh.20 for ; Mon, 13 Jun 2011 06:11:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.137.5 with SMTP id u5mr3283019qat.97.1307970686518; Mon, 13 Jun 2011 06:11:26 -0700 (PDT) Received: by 10.229.47.78 with HTTP; Mon, 13 Jun 2011 06:11:26 -0700 (PDT) In-Reply-To: References: <4DF26301.9020208@redhat.com> Date: Mon, 13 Jun 2011 15:24:00 -0000 Message-ID: Subject: Re: [Patch : H8300] Bug fix for bit insn and minor tweaks to insns From: "H.J. Lu" To: Kaushik Phatak Cc: Jeff Law , "gcc-patches@gcc.gnu.org" , Prafulla Thakare Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00973.txt.bz2 On Mon, Jun 13, 2011 at 2:40 AM, Kaushik Phatak wrote: > Hi Jeff, > Thanks for the quick review. > >>> the right test is rtx_equal_p(operands[0], operands[1]) > Committed with above changes to the bsetqi_msx, bclrqi_msx and bnotqi_msx patterns. > Commit is incorrect. Testsuite ChangeLog entries should be in testsuite/ChangeLog. You have duplicated lines in gcc.dg/h8300-bit-insn-ice2.c and filename is ChangeLog is incorrect. I checked in this fix. -- H.J. --- Index: ChangeLog =================================================================== --- ChangeLog (revision 174986) +++ ChangeLog (working copy) @@ -4,7 +4,6 @@ condition to disallow non-identical memory locations. (*andqi3_2, andqi3_1, iorqi3_1, xorqi3_1): Reorder insn to give preference to bit manipulation instructions. - * gcc.dg/h8300-bit-insn-ice2.2: New testcase. 2011-06-13 Jan Hubicka Index: testsuite/gcc.dg/h8300-bit-insn-ice2.c =================================================================== --- testsuite/gcc.dg/h8300-bit-insn-ice2.c (revision 174986) +++ testsuite/gcc.dg/h8300-bit-insn-ice2.c (working copy) @@ -13,18 +13,3 @@ main (void) MSTPCRA = MSTPCRA2 | ~0xFE; return 0; } -/* { dg-skip-if "" { "h8300*-*-*" } "*" "-msx*" } */ -/* { dg-options "-O2" } */ -/* ICE for bit instruction generation using 16-bit const */ - -#define MSTPCRA (*(volatile unsigned char*)0xFFFFC9) -#define MSTPCRA2 (*(volatile unsigned char*)0xFFFDC8) - -int -main (void) -{ - MSTPCRA = MSTPCRA2 & ~0x01; - MSTPCRA = MSTPCRA2 ^ ~0xFE; - MSTPCRA = MSTPCRA2 | ~0xFE; - return 0; -} Index: testsuite/ChangeLog =================================================================== --- testsuite/ChangeLog (revision 174986) +++ testsuite/ChangeLog (working copy) @@ -1,3 +1,11 @@ +2011-06-13 H.J. Lu + + * gcc.dg/h8300-bit-insn-ice2.c: Remove duplicated lines. + +2011-06-13 Kaushik Phatak + + * gcc.dg/h8300-bit-insn-ice2.c: New testcase. + 2011-06-13 Thomas Koenig * gfortran.dg/trim_optimize_8.f90: New test case.