From: Denis Chertykov <chertykov@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches@gcc.gnu.org, Anatoly Sokolov <aesok@post.ru>,
Eric Weddington <eric.weddington@atmel.com>
Subject: Re: [Patch,AVR]: FIX ICE in optabs due to bad rotate expander.
Date: Wed, 20 Apr 2011 12:56:00 -0000 [thread overview]
Message-ID: <BANLkTimMkV57hAO6tmfJgEZGUBixifDTtw@mail.gmail.com> (raw)
In-Reply-To: <4DAEB320.6000803@gjlay.de>
2011/4/20 Georg-Johann Lay <avr@gjlay.de>:
> Denis Chertykov schrieb:
>> 2011/4/17 Denis Chertykov <chertykov@gmail.com>:
>>> 2011/4/15 Georg-Johann Lay <avr@gjlay.de>:
>>>> Finally, I exposed alternative #3 of the insns to the register
>>>> allocator, because it is not possible to distinguish between
>>>> overlapping or non-overlapping regs, and #3 does not need a scratch.
>>>>
>>>> Ran C-testsuite with no regressions.
>>> Are you encountered any difference in code size ?
>>
>> I'm ask about code size because the IRA pass isn't work with
>> `scratch:MODE' at all.
>> This lead to bad/wrong register allocation in IRA pass.
>> The reload pass will correct such a wrong allocation, but reload can't
>> generate optimal code. (reload generate correct code).
>> Because of that, may be you right and may be better to have
>> (clobber (match_operand....)) instead of (clobber (match_scratch...)).
>
> So the conclusion is not to commit this patch and that the one-liner
> already installed is sufficient to fix the ICE?
Yes.
Denis.
prev parent reply other threads:[~2011-04-20 11:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 10:25 Georg-Johann Lay
2011-04-14 16:21 ` Denis Chertykov
2011-04-14 17:20 ` Georg-Johann Lay
2011-04-14 18:15 ` Denis Chertykov
2011-04-15 17:56 ` Georg-Johann Lay
2011-04-17 10:23 ` Denis Chertykov
2011-04-17 19:43 ` Denis Chertykov
2011-04-18 11:10 ` Georg-Johann Lay
2011-04-18 16:35 ` Denis Chertykov
2011-04-18 16:46 ` Denis Chertykov
2011-04-19 9:46 ` Georg-Johann Lay
2011-04-19 10:16 ` Denis Chertykov
2011-04-19 10:36 ` Georg-Johann Lay
2011-04-19 12:07 ` Denis Chertykov
2011-04-19 13:15 ` Richard Earnshaw
2011-04-20 17:44 ` Richard Henderson
2011-04-20 11:25 ` Georg-Johann Lay
2011-04-20 12:56 ` Denis Chertykov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimMkV57hAO6tmfJgEZGUBixifDTtw@mail.gmail.com \
--to=chertykov@gmail.com \
--cc=aesok@post.ru \
--cc=avr@gjlay.de \
--cc=eric.weddington@atmel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).