From: Richard Guenther <richard.guenther@gmail.com>
To: Diego Novillo <dnovillo@google.com>
Cc: crowl@google.com, jason@redhat.com, gcc-patches@gcc.gnu.org,
reply@codereview.appspotmail.com
Subject: Re: Add debugging functions for cp_parser (issue4389045)
Date: Wed, 13 Apr 2011 12:39:00 -0000 [thread overview]
Message-ID: <BANLkTimQp1_7aHJVt0FNYCokLCGioht4OQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTim6i7FuWNX49orYOg83pUFwZM5B_g@mail.gmail.com>
On Wed, Apr 13, 2011 at 2:29 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Wed, Apr 13, 2011 at 05:25, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> On Wed, Apr 13, 2011 at 2:02 AM, <crowl@google.com> wrote:
>>> One oddity, otherwise LGTM.
>>>
>>>
>>> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c
>>> File gcc/cp/parser.c (right):
>>>
>>> http://codereview.appspot.com/4389045/diff/1/gcc/cp/parser.c#newcode375
>>> gcc/cp/parser.c:375: if (flag)
>>> This code will never print "false", so why have it?
>>
>> Can you quote the piece of the patch you are commenting on?
>
> I'm not sure if that can be controlled. When you respond to a hunk on
> Rietveld, it creates the quote automatically. Maybe there is a way of
> increasing the scope of the quote. I'll ask.
Quoting the patch hunk that is associated with the commend would be enough.
Richard.
> Diego.
>
next prev parent reply other threads:[~2011-04-13 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 0:02 crowl
2011-04-13 0:53 ` Diego Novillo
2011-04-13 9:25 ` Richard Guenther
2011-04-13 12:29 ` Diego Novillo
2011-04-13 12:39 ` Richard Guenther [this message]
2011-04-13 12:49 ` Diego Novillo
-- strict thread matches above, loose matches on Subject: below --
2011-04-11 16:24 Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimQp1_7aHJVt0FNYCokLCGioht4OQ@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=crowl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).