From: "H.J. Lu" <hjl.tools@gmail.com>
To: Richard Guenther <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Diego Novillo <dnovillo@google.com>
Subject: Re: [PATCH] FIx PR47647, revert an earlier patch
Date: Mon, 25 Apr 2011 11:44:00 -0000 [thread overview]
Message-ID: <BANLkTimWR-5Pkh=45DAaVK8vWhg5L7drMQ@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimjTvRXyNN1uycHBS=geu7pBW-DCC_xyraZBZSS@mail.gmail.com>
On Sat, Feb 19, 2011 at 4:52 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Feb 18, 2011 at 8:19 AM, Richard Guenther <rguenther@suse.de> wrote:
>>
>> This reverts lazy BLOCK_VARS streaming as I thought back in time
>> that VAR_DECLs have BLOCKs as DECL_CONTEXT while they have
>> FUNCTION_DECLs ... so the patch doesn't work at all and instead
>> causes us to not stream in any BLOCKs, resulting in no local
>> decls at all in debug info. Not good.
>>
>> Fixed with the following which also makes latent guality issues
>> re-appear - they were hidden by
>>
>> pr41353-1.gdb:3: Error in sourced command file:^M
>> No symbol "vari2" in current context.^M
>> UNSUPPORTED: gcc.dg/guality/pr41353-1.c -O2 -flto -flto-partition=none
>> line 17 vari2 == 3 * 17
>>
>> where "No symbol "vari2" in current context" isn't treated the
>> same as "<optimized out>" ...
>>
>> I have filed bugs for some LTO debug info issues I noticed.
>>
>> Bootstrapped and tested on x86_64-unknown-linux-gnu, ok?
>>
>> Thanks,
>> Richard.
>>
>> 2011-02-18 Richard Guenther <rguenther@suse.de>
>>
>> PR lto/47647
>> * lto-streamer-in.c (lto_input_ts_decl_minimal_tree_pointers):
>> Remove lazy BLOCK_VARS streaming.
>> (lto_input_ts_block_tree_pointers): Likewise.
>> * lto-streamer-out.c (lto_output_ts_block_tree_pointers): Likewise.
>>
>
> This may have caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47820
>
This also caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48354
--
H.J.
prev parent reply other threads:[~2011-04-25 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 16:41 Richard Guenther
2011-02-18 18:56 ` Diego Novillo
2011-02-20 11:12 ` H.J. Lu
2011-04-25 11:44 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimWR-5Pkh=45DAaVK8vWhg5L7drMQ@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).