From: Kai Tietz <ktietz70@googlemail.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Eric Botcazou <ebotcazou@adacore.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch gimplifier]: Change TRUTH_(AND|OR|XOR) expressions to binary form
Date: Thu, 19 May 2011 13:01:00 -0000 [thread overview]
Message-ID: <BANLkTimWRKZAmkPcHLafNegwJy_tNecT8g@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=s2Au_C=+M_F+QfPuOV54V2GSChg@mail.gmail.com>
2011/5/19 Richard Guenther <richard.guenther@gmail.com>:
> On Thu, May 19, 2011 at 12:45 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>>> Eric, how will this interact with Ada boolean types with 8 bit precision
>>> and those "invalid" values - will invalid values ever enter into
>>> expressions or are they checked before?
>>
>> IIUC the Ada semantics is that they must be checked prior to being used. Once
>> they are used, they are "recycled" into valid values. So the issue boils down
>> to how the check is implemented and it doesn't use TRUTH_(AND|OR|XOR) at all.
>>
>>> Can you think of something that would break with s/TRUTH_*_EXPR/BIT_*_EXPR/
>>> for Ada?
>>
>> No, not at the moment. Thanks for asking in any case.
>
> Kai, the patch is ok then with the comment added.
>
> Thanks,
> Richard.
>
>> --
>> Eric Botcazou
>>
Committed at revision 173903 with suggested comment.
Regards,
Kai
prev parent reply other threads:[~2011-05-19 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 17:14 Kai Tietz
2011-05-18 19:35 ` Kai Tietz
2011-05-19 12:31 ` Richard Guenther
2011-05-19 12:57 ` Eric Botcazou
2011-05-19 12:59 ` Richard Guenther
2011-05-19 13:01 ` Kai Tietz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimWRKZAmkPcHLafNegwJy_tNecT8g@mail.gmail.com \
--to=ktietz70@googlemail.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).