From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23777 invoked by alias); 19 May 2011 11:17:22 -0000 Received: (qmail 23767 invoked by uid 22791); 19 May 2011 11:17:21 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 11:17:04 +0000 Received: by qwh5 with SMTP id 5so1465264qwh.20 for ; Thu, 19 May 2011 04:17:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.7.3 with SMTP id b3mr2255177qcb.194.1305803823262; Thu, 19 May 2011 04:17:03 -0700 (PDT) Received: by 10.229.33.209 with HTTP; Thu, 19 May 2011 04:17:03 -0700 (PDT) In-Reply-To: References: <201105191245.02882.ebotcazou@adacore.com> Date: Thu, 19 May 2011 13:01:00 -0000 Message-ID: Subject: Re: [patch gimplifier]: Change TRUTH_(AND|OR|XOR) expressions to binary form From: Kai Tietz To: Richard Guenther Cc: Eric Botcazou , GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01369.txt.bz2 2011/5/19 Richard Guenther : > On Thu, May 19, 2011 at 12:45 PM, Eric Botcazou w= rote: >>> Eric, how will this interact with Ada boolean types with 8 bit precision >>> and those "invalid" values - will invalid values ever enter into >>> expressions or are they checked before? >> >> IIUC the Ada semantics is that they must be checked prior to being used.= =A0Once >> they are used, they are "recycled" into valid values. =A0So the issue bo= ils down >> to how the check is implemented and it doesn't use TRUTH_(AND|OR|XOR) at= all. >> >>> Can you think of something that would break with s/TRUTH_*_EXPR/BIT_*_E= XPR/ >>> for Ada? >> >> No, not at the moment. =A0Thanks for asking in any case. > > Kai, the patch is ok then with the comment added. > > Thanks, > Richard. > >> -- >> Eric Botcazou >> Committed at revision 173903 with suggested comment. Regards, Kai