From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8559 invoked by alias); 23 May 2011 09:30:53 -0000 Received: (qmail 8547 invoked by uid 22791); 23 May 2011 09:30:52 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-wy0-f175.google.com (HELO mail-wy0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 09:30:35 +0000 Received: by wye20 with SMTP id 20so4902581wye.20 for ; Mon, 23 May 2011 02:30:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.227.55.74 with SMTP id t10mr2023305wbg.91.1306143034185; Mon, 23 May 2011 02:30:34 -0700 (PDT) Received: by 10.227.38.129 with HTTP; Mon, 23 May 2011 02:30:34 -0700 (PDT) In-Reply-To: <20110523103355.71528d09@zenwalk.local> References: <20110523103355.71528d09@zenwalk.local> Date: Mon, 23 May 2011 10:22:00 -0000 Message-ID: Subject: Re: external declaration of dominance debug functions From: Richard Guenther To: Piervit Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01603.txt.bz2 On Mon, May 23, 2011 at 10:33 AM, Piervit wrote: > Hello, > > Here is a two lines patch, allowing to use debug_dominance_info and > debug_dominance_tree functions outside of gcc/dominance.c. For the > moment, those functions are not declared in any gcc/*.h files (as far as > I know after trying a grep). I have added them as external functions > into gcc/basic-block.h. I feel this is useful to be able to call those > functions from others files, for exemple from plugins. debug_* functions are supposed to be used from interactive gdb sessions. They should not be advertised in public headers. Richard. > ChangeLog: > > 2011-05-23 =A0Pierre Vittet =A0 > > =A0 =A0 =A0 =A0* basic-block.h (debug_dominance_info, debug_dominance_tre= e): > =A0 =A0 =A0 =A0 =A0Add declaration.