From: Diego Novillo <dnovillo@google.com>
To: Gabriel Charette <gchare@google.com>
Cc: reply@codereview.appspotmail.com,
Lawrence Crowl <crowl@google.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [pph] Removing pth implementation from pph implementation (issue4571047)
Date: Mon, 06 Jun 2011 22:14:00 -0000 [thread overview]
Message-ID: <BANLkTimZwQs2sXgd=mAM+tZ3LnOVKmXZXw@mail.gmail.com> (raw)
In-Reply-To: <20110606220830.AB7591C37DF@gchare.mtv.corp.google.com>
On Mon, Jun 6, 2011 at 18:08, Gabriel Charette <gchare@google.com> wrote:
> Removed all of the pth code with the exception of pth_save_token_cache
> and pth_load_token_cache and their respective closure.
>
> The renaming of the remaining functions to pph will be done in a separate patch.
>
> The patch was tested with a full bootstrap build and regression testing.
>
> Note: There might be header files that are now unused due to the code removed.
>
> 2011-06-06 Gabriel Charette <gchare@google.com>
>
> * gcc/c-family/c.opt (fpth): Remove. Update all users.
> (fpth-debug): Likewise.
> (fpth-stats). Likewise.
> (fpth-md5). Likewise.
> * gcc/cp/pph.c (pth_stats): Remove field. Update all users.
> (pth_get_state): Remove. Update all users.
> (pth_debug_identifiers): Likewise.
> (pth_debug_token_hunks): Likewise.
> (pth_debug_state): Likewise.
> (pth_image_lookup): Likewise.
> (pth_init): Likewise.
> (pth_print_stats): Likewise.
> (pth_finish): Likewise.
> * gcc/cp/pph.h (struct pth_include): Likewise.
> (struct pth_image): Likewise.
> (struct pth_state): Likewise.
> (PTH_STATS_INCR): Likewise.
> * gcc/timevar.def (TV_PTH_DEPENDENCY): Likewise.
> (TV_PTH_MANAGE): Likewise.
> (TV_PTH_MD5): Likewise.
> (TV_PTH_LOAD): Likewise.
> (TV_PTH_SAVE): Likewise.
> (TV_PTH_SKIP_TOKENS): Likewise.
> (TV_PTH_INIT): Likewise.
You also need to remove all the pth support in the testsuite. You'd
be getting tons of errors from pth.exp. Essentially, everything in
gcc/testsuite/* that references pth can go. This includes
gcc/testsuite/lib/dg-pth.exp, gcc/testsuite/g++.dg/pth/* and also
you'll have to edit gcc/testsuite/g++.dg/dg.exp to remove the code
that tries to execute pth.exp.
OK with that change.
Diego.
next prev parent reply other threads:[~2011-06-06 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 22:09 Gabriel Charette
2011-06-06 22:14 ` Diego Novillo [this message]
2011-06-06 23:13 Gabriel Charette
2011-06-07 18:45 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimZwQs2sXgd=mAM+tZ3LnOVKmXZXw@mail.gmail.com' \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gchare@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).