From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25453 invoked by alias); 6 Jun 2011 22:14:45 -0000 Received: (qmail 25445 invoked by uid 22791); 6 Jun 2011 22:14:44 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_50,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jun 2011 22:14:30 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id p56METG3015792 for ; Mon, 6 Jun 2011 15:14:29 -0700 Received: from gwj15 (gwj15.prod.google.com [10.200.10.15]) by wpaz5.hot.corp.google.com with ESMTP id p56MCcRN002702 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 6 Jun 2011 15:14:28 -0700 Received: by gwj15 with SMTP id 15so2312033gwj.25 for ; Mon, 06 Jun 2011 15:14:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.230.12 with SMTP id c12mr4833120ybh.13.1307398467779; Mon, 06 Jun 2011 15:14:27 -0700 (PDT) Received: by 10.151.41.13 with HTTP; Mon, 6 Jun 2011 15:14:27 -0700 (PDT) In-Reply-To: <20110606220830.AB7591C37DF@gchare.mtv.corp.google.com> References: <20110606220830.AB7591C37DF@gchare.mtv.corp.google.com> Date: Mon, 06 Jun 2011 22:14:00 -0000 Message-ID: Subject: Re: [pph] Removing pth implementation from pph implementation (issue4571047) From: Diego Novillo To: Gabriel Charette Cc: reply@codereview.appspotmail.com, Lawrence Crowl , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00470.txt.bz2 On Mon, Jun 6, 2011 at 18:08, Gabriel Charette wrote: > Removed all of the pth code with the exception of pth_save_token_cache > and pth_load_token_cache and their respective closure. > > The renaming of the remaining functions to pph will be done in a separate= patch. > > The patch was tested with a full bootstrap build and regression testing. > > Note: There might be header files that are now unused due to the code rem= oved. > > 2011-06-06 =C2=A0Gabriel Charette =C2=A0 > > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gcc/c-family/c.opt (fpth): Remove. Update al= l users. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(fpth-debug): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(fpth-stats). Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(fpth-md5). Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gcc/cp/pph.c (pth_stats): Remove field. Upda= te all users. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_get_state): Remove. Update all users. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_debug_identifiers): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_debug_token_hunks): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_debug_state): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_image_lookup): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_init): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_print_stats): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(pth_finish): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gcc/cp/pph.h (struct pth_include): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(struct pth_image): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(struct pth_state): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(PTH_STATS_INCR): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0* gcc/timevar.def (TV_PTH_DEPENDENCY): Likewis= e. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(TV_PTH_MANAGE): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(TV_PTH_MD5): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(TV_PTH_LOAD): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(TV_PTH_SAVE): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(TV_PTH_SKIP_TOKENS): Likewise. > =C2=A0 =C2=A0 =C2=A0 =C2=A0(TV_PTH_INIT): Likewise. You also need to remove all the pth support in the testsuite. You'd be getting tons of errors from pth.exp. Essentially, everything in gcc/testsuite/* that references pth can go. This includes gcc/testsuite/lib/dg-pth.exp, gcc/testsuite/g++.dg/pth/* and also you'll have to edit gcc/testsuite/g++.dg/dg.exp to remove the code that tries to execute pth.exp. OK with that change. Diego.